feat: add unit tests and benchmark for isArray#252
Merged
yceffort-naver merged 1 commit intoNaverPayDev:mainfrom May 6, 2025
Merged
feat: add unit tests and benchmark for isArray#252yceffort-naver merged 1 commit intoNaverPayDev:mainfrom
yceffort-naver merged 1 commit intoNaverPayDev:mainfrom
Conversation
- Added isArray.test.ts for verifying functionality - Added isArray.bench.ts for performance comparison with lodash
Contributor
|
✅ All utility modules are properly registered in |
Contributor
Benchmark Results
View Full Benchmark Data{
"files": [
{
"filepath": "/home/runner/work/hidash/hidash/src/isArray.bench.ts",
"groups": [
{
"fullName": "src/isArray.bench.ts > isArray performance",
"benchmarks": [
{
"id": "1080123271_0_0",
"name": "hidash",
"rank": 1,
"rme": 0.4986020908109256,
"samples": [],
"totalTime": 501.12418400000024,
"min": 1.7790019999999913,
"max": 2.820974000000035,
"hz": 516.837958073881,
"period": 1.9348424092664103,
"mean": 1.9348424092664103,
"variance": 0.006274613910987065,
"sd": 0.07921246057904693,
"sem": 0.004922022809438167,
"df": 258,
"critical": 1.96,
"moe": 0.009647164706498807,
"p75": 1.9460749999999507,
"p99": 2.2879349999999476,
"p995": 2.4738739999999666,
"p999": 2.820974000000035,
"sampleCount": 259,
"median": 1.9275199999999586
},
{
"id": "1080123271_0_1",
"name": "lodash",
"rank": 2,
"rme": 0.16427843463533898,
"samples": [],
"totalTime": 516.7567079999994,
"min": 17.065432999999985,
"max": 17.442688999999973,
"hz": 58.05439878295693,
"period": 17.225223599999982,
"mean": 17.225223599999982,
"variance": 0.0057441461101094835,
"sd": 0.07579014520443593,
"sem": 0.013837324055020516,
"df": 29,
"critical": 2.045,
"moe": 0.028297327692516954,
"p75": 17.271789999999896,
"p99": 17.442688999999973,
"p995": 17.442688999999973,
"p999": 17.442688999999973,
"sampleCount": 30,
"median": 17.226079000000027
}
]
}
]
}
]
}Last updated by GitHub Actions |
yceffort-naver
approved these changes
May 2, 2025
Contributor
yceffort-naver
left a comment
yceffort-naver
left a comment
There was a problem hiding this comment.
Thanks for consistently contributing to hidash. Feel free to merge whenever you’re ready. 🚀
Contributor
Author
|
I have a question since I couldn't see the merge button, I was wondering how I should go about merging. Could you let me know the proper way to do it? |
Contributor
|
Oh, sorry about that—I didn’t realize external contributors couldn’t see the merge button. I’ll go ahead and merge it myself. Thanks again! 😊 |
Contributor
Author
|
Yes, thank you as always 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test
Benchmark
