Skip to content

Conversation

@acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Fixes more instances of unnamed QMutexLocker objects that were not holding the lock for the duration of the containing scope.

Have you tested your changes (if applicable)? If so, how?

Yes. Built locally and tested with by doing a bunch of zoom and userRoi changes. I didn't notice any issues like deadlocking or odd behavior. This is a pretty low risk fix since all the logic covered by the locks are simple member variable updates.

Fixes more instances of unnamed QMutexLocker objects that were
not holding the lock for the duration of the containing scope.
Copy link
Member

@devernay devernay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!

@devernay devernay merged commit d03dc06 into NatronGitHub:RB-2.5 Mar 12, 2024
@acolwell acolwell deleted the fix_more_qmutexlockers branch June 30, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants