Fix freeze in Tracker when not in viewer path #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
When a tracker node outside of the viewer has one of its button clicked Natron might freeze due to some knobs request a viewport that the node doesn't have because its not connected to any. This PR fixes this by checking if an overlay is available and proceed with the knobs, ignores the action otherwise.
Show a few screenshots (if this is a visual change)
N/A.
Have you tested your changes (if applicable)? If so, how?
By adding a tracker node outside of a viewer path and
Futher details of this pull request
Fixes #299.