Repository navigation
Preserve template namespaces before operator-> and operator->* - #10054
Merged
ryanmkurtz merged 1 commit intoOct 30, 2026
Merged
ryanmkurtz merged 1 commit into
ryanmkurtz merged 1 commit into
Conversation
The '>' in operator-> and operator->* leaves the template counter unbalanced, so SymbolPathParser fell back to splitting on every "::", including the ones inside template arguments. Treat both like the other terminal angle operators. AI-generated by Claude Code. Co-Authored-By: Claude Opus 5.5 <[email protected]>
dragonmacher
approved these changes
Oct 28, 2026
ryanmkurtz
added
Status: Internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PDB applicator builds function namespaces with
new SymbolPath(name)(FunctionSymbolApplier.getReconciledSymbolPath), andMDMangUtils.consolidateSymbolPathalso runs PDB names throughSymbolPathParser. For MSVC names likethe
>inoperator->leaves the template counter unbalanced, so the parser falls back to splitting on every::and returnsinstead of
[std, unique_ptr<A::B,std::default_delete<A::B> >, operator->].operator->onstd::unique_ptrand the STL iterators is very common in C++ programs, so their functions land in made-up namespaces.operator->*hits the same path.#9851 handled this for
operator<,operator<<,operator<=>and the rest; this addsoperator->andoperator->*to the same list.I checked it with two extra cases in
SymbolPathParserTest(both fail before, pass after;SymbolPathTestandGnuDemanglerParser2Teststill pass). Following CONTRIBUTING, I left those tests out of this PR, but can add them if you want.AI-generated by Claude Code.
I used Claude Code to write this change.