Look up for null pointer in array pool

romainbrenguier · romainbrenguier · commit 3c7a671d16bf · 2018-06-18T07:20:06.000+01:00
make_char_array was returning a new symbol every time NULL was
encountered which is a problem when we want to compare these symbols.
diff --git a/src/solvers/refinement/string_constraint_generator_main.cpp b/src/solvers/refinement/string_constraint_generator_main.cpp
@@ -220,14 +220,7 @@ array_string_exprt array_poolt::make_char_array_for_char_pointer(
   else if(
     char_pointer.id() == ID_constant &&
     to_constant_expr(char_pointer).get_value() == ID_NULL)
-  {
-    /// \todo Check if the case char_array_null occurs.
-    array_typet array_type(
-      char_array_type.subtype(),
-      from_integer(0, to_array_type(char_array_type).size().type()));
-    symbol_exprt array_sym = fresh_symbol("char_array_null", array_type);
-    return to_array_string_expr(array_sym);
-  }
+    symbol_name = "char_array_null";
   else
     symbol_name = "unknown_char_array";
 
