Merge pull request diffblue#2545 from tautschnig/vs-unnecessary

tautschnig · web-flow · commit 2d14b22c2287 · 2018-07-19T17:11:04.000+01:00
Avoid unncessary signed/unsigned conversion
diff --git a/src/goto-instrument/accelerate/polynomial.cpp b/src/goto-instrument/accelerate/polynomial.cpp
@@ -138,15 +138,8 @@ void polynomialt::from_expr(const exprt &expr)
   }
   else if(expr.id()==ID_constant)
   {
-    mp_integer mp;
-    unsigned int l;
-    constant_exprt const_expr=to_constant_expr(expr);
-
-    mp=binary2integer(const_expr.get_value().c_str(), true);
-    l=mp.to_long();
-
     monomialt monomial;
-    monomial.coeff=l;
+    monomial.coeff = numeric_cast_v<int>(expr);
 
     monomials.push_back(monomial);
   }

Original file line number	Diff line number	Diff line change
`@@ -138,15 +138,8 @@ void polynomialt::from_expr(const exprt &expr)`
`138`	`138`	`}`
`139`	`139`	`else if(expr.id()==ID_constant)`
`140`	`140`	`{`
`141`		`- mp_integer mp;`
`142`		`- unsigned int l;`
`143`		`- constant_exprt const_expr=to_constant_expr(expr);`
`144`		`-`
`145`		`- mp=binary2integer(const_expr.get_value().c_str(), true);`
`146`		`- l=mp.to_long();`
`147`		`-`
`148`	`141`	`monomialt monomial;`
`149`		`- monomial.coeff=l;`
	`142`	`+ monomial.coeff = numeric_cast_v<int>(expr);`
`150`	`143`
`151`	`144`	`monomials.push_back(monomial);`
`152`	`145`	`}`