Conversation
Contributor
jmarrec
commented
Dec 8, 2025
jmarrec
commented
- cf https://github.com/NREL/openstudio-extension-gem/pull/220/files
jmarrec
added a commit
to NatLabRockies/openstudio-gems
that referenced
this pull request
Dec 8, 2025
anchapin
added a commit
that referenced
this pull request
Dec 15, 2025
* Bump version to 0.9.5 and prepare release (#217) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> * Bump to 0.9.6 and undo broken changes (#221) * Bump to 0.9.6 and undo broken changes cf https://github.com/NREL/openstudio-extension-gem/pull/220/files * Fix CI issues related to bundle install * Run bundle commands in unbundled environment to avoid nested bundler conflicts * Add parser dependency to avoid test_with_openstudio errors --------- Co-authored-by: Alex Chapin <[email protected]> * Fix Gemfile source URL and update Jenkinsfile library reference (#222) --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> Co-authored-by: Julien Marrec <[email protected]>
jmarrec
commented
Dec 15, 2025
| spec.add_dependency 'addressable', '2.8.1' | ||
| spec.add_dependency 'parallel', '~> 1.19.1' | ||
| spec.add_dependency 'regexp_parser', '>= 2.9.0' | ||
| spec.add_dependency 'parser', '< 3.3.0' |
Contributor
Author
There was a problem hiding this comment.
That should be pinned exactly, I think you want
spec.add_dependency 'parser', '3.2.2.2'
NatLabRockies/OpenStudio-measure-tester-gem#67
Also, I find it weird that you have to add it, since the openstudio_measure_tester has it. I think the issue is that the openstudio measure test was broken recently when it updated the gems there.
Contributor
Author
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
@jmarrec what's the best solution for this? Should I make a new version 0.9.7 for this change or just make note of this and fix it when making 0.9.7? Also, it sounds like you indicated that the 'parser' dependency isn't need to be listed here once it is fixed in measure-tester-gem.
anchapin
added a commit
that referenced
this pull request
Dec 17, 2025
* Bump version to 0.9.5 and prepare release (#217) (#219) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> * Release v0.9.6 (#223) * Bump version to 0.9.5 and prepare release (#217) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> * Bump to 0.9.6 and undo broken changes (#221) * Bump to 0.9.6 and undo broken changes cf https://github.com/NREL/openstudio-extension-gem/pull/220/files * Fix CI issues related to bundle install * Run bundle commands in unbundled environment to avoid nested bundler conflicts * Add parser dependency to avoid test_with_openstudio errors --------- Co-authored-by: Alex Chapin <[email protected]> * Fix Gemfile source URL and update Jenkinsfile library reference (#222) --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> Co-authored-by: Julien Marrec <[email protected]> * Rubocop fixes (#224) * Hard code rubocop version to 1.50.0 * Remove rubocop performance * Refactor gemspec to streamline file listing and remove unused parser dependency * Update gemspec to use Dir.glob for file listing and remove unused git command * Prep for 0.9.7 release --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> Co-authored-by: Julien Marrec <[email protected]>
anchapin
added a commit
that referenced
this pull request
Dec 17, 2025
* Bump version to 0.9.5 and prepare release (#217) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> * Bump to 0.9.6 and undo broken changes (#221) * Bump to 0.9.6 and undo broken changes cf https://github.com/NREL/openstudio-extension-gem/pull/220/files * Fix CI issues related to bundle install * Run bundle commands in unbundled environment to avoid nested bundler conflicts * Add parser dependency to avoid test_with_openstudio errors --------- Co-authored-by: Alex Chapin <[email protected]> * Fix Gemfile source URL and update Jenkinsfile library reference (#222) * Remove parser dependency and prep for 0.9.7 (#226) * Bump version to 0.9.5 and prepare release (#217) (#219) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> * Release v0.9.6 (#223) * Bump version to 0.9.5 and prepare release (#217) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> * Bump to 0.9.6 and undo broken changes (#221) * Bump to 0.9.6 and undo broken changes cf https://github.com/NREL/openstudio-extension-gem/pull/220/files * Fix CI issues related to bundle install * Run bundle commands in unbundled environment to avoid nested bundler conflicts * Add parser dependency to avoid test_with_openstudio errors --------- Co-authored-by: Alex Chapin <[email protected]> * Fix Gemfile source URL and update Jenkinsfile library reference (#222) --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> Co-authored-by: Julien Marrec <[email protected]> * Rubocop fixes (#224) * Hard code rubocop version to 1.50.0 * Remove rubocop performance * Refactor gemspec to streamline file listing and remove unused parser dependency * Update gemspec to use Dir.glob for file listing and remove unused git command * Prep for 0.9.7 release --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> Co-authored-by: Julien Marrec <[email protected]> * Revert "Remove parser dependency and prep for 0.9.7 (#226)" This reverts commit a64c11c. * Remove parser and prep for v0.9.7 (#227) * Refactor gemspec to streamline file listing and remove unused parser dependency * Update gemspec to use Dir.glob for file listing and remove unused git command * Prep for 0.9.7 release --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> Co-authored-by: Julien Marrec <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.