Conversation
* Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]>
jmarrec
reviewed
Dec 4, 2025
Comment on lines
22
to
+29
|
|
||
| spec.files = `git ls-files -z`.split("\x0").reject do |f| | ||
| files = `git ls-files -z`.split("\x0") | ||
| if files.empty? | ||
| files = Dir.glob('**/*', File::FNM_DOTMATCH).select do |f| | ||
| File.file?(f) && !f.match(%r{^(\.git|\.bundle|pkg|coverage|doc|_yardoc|\.yardoc)/}) && !f.match(%r{^Gemfile\.lock$}) | ||
| end | ||
| end | ||
| spec.files = files.reject do |f| |
Contributor
There was a problem hiding this comment.
Was something not working before?
Collaborator
Author
There was a problem hiding this comment.
I don't remember actually, but I'm fine with reverting it back.
Comment on lines
+45
to
+51
| spec.add_dependency 'addressable', '>= 2.8.1' | ||
| spec.add_dependency 'parallel', '~> 1.19.1' | ||
| spec.add_dependency 'regexp_parser', '2.9.0' | ||
| spec.add_dependency 'regexp_parser', '>= 2.9.0' | ||
| spec.add_development_dependency 'rake', '~> 13.0' | ||
| spec.add_development_dependency 'rspec', '~> 3.9' | ||
| spec.add_development_dependency 'rubocop', '1.50' | ||
| spec.add_development_dependency 'rubocop', '>= 1.50.0' | ||
| spec.add_development_dependency 'rubocop-performance' |
Contributor
There was a problem hiding this comment.
Same comment as on github.com/NatLabRockies/OpenStudio-measure-tester-gem/pull/96#discussion_r2588716015
The gem ecosystem is fragile since everything has to align, I would refrain from touching that stuff unless you're 1) absolutely sure of what you're doing and 2) working with all gem repos in parallel
anchapin
added a commit
that referenced
this pull request
Dec 17, 2025
* Bump version to 0.9.5 and prepare release (#217) (#219) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> * Release v0.9.6 (#223) * Bump version to 0.9.5 and prepare release (#217) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> * Bump to 0.9.6 and undo broken changes (#221) * Bump to 0.9.6 and undo broken changes cf https://github.com/NREL/openstudio-extension-gem/pull/220/files * Fix CI issues related to bundle install * Run bundle commands in unbundled environment to avoid nested bundler conflicts * Add parser dependency to avoid test_with_openstudio errors --------- Co-authored-by: Alex Chapin <[email protected]> * Fix Gemfile source URL and update Jenkinsfile library reference (#222) --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> Co-authored-by: Julien Marrec <[email protected]> * Rubocop fixes (#224) * Hard code rubocop version to 1.50.0 * Remove rubocop performance * Refactor gemspec to streamline file listing and remove unused parser dependency * Update gemspec to use Dir.glob for file listing and remove unused git command * Prep for 0.9.7 release --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> Co-authored-by: Julien Marrec <[email protected]>
anchapin
added a commit
that referenced
this pull request
Dec 17, 2025
* Bump version to 0.9.5 and prepare release (#217) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> * Bump to 0.9.6 and undo broken changes (#221) * Bump to 0.9.6 and undo broken changes cf https://github.com/NREL/openstudio-extension-gem/pull/220/files * Fix CI issues related to bundle install * Run bundle commands in unbundled environment to avoid nested bundler conflicts * Add parser dependency to avoid test_with_openstudio errors --------- Co-authored-by: Alex Chapin <[email protected]> * Fix Gemfile source URL and update Jenkinsfile library reference (#222) * Remove parser dependency and prep for 0.9.7 (#226) * Bump version to 0.9.5 and prepare release (#217) (#219) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> * Release v0.9.6 (#223) * Bump version to 0.9.5 and prepare release (#217) * Bump version to 0.9.5 and prepare release - Update version to 0.9.5 - Update CHANGELOG.md and README.md - Add rubocop-performance to gemspec * prep version 0.9.4 * fix: update rubygems source to HTTPS and add gemspec file listing fallback. --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> * Bump to 0.9.6 and undo broken changes (#221) * Bump to 0.9.6 and undo broken changes cf https://github.com/NREL/openstudio-extension-gem/pull/220/files * Fix CI issues related to bundle install * Run bundle commands in unbundled environment to avoid nested bundler conflicts * Add parser dependency to avoid test_with_openstudio errors --------- Co-authored-by: Alex Chapin <[email protected]> * Fix Gemfile source URL and update Jenkinsfile library reference (#222) --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> Co-authored-by: Julien Marrec <[email protected]> * Rubocop fixes (#224) * Hard code rubocop version to 1.50.0 * Remove rubocop performance * Refactor gemspec to streamline file listing and remove unused parser dependency * Update gemspec to use Dir.glob for file listing and remove unused git command * Prep for 0.9.7 release --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> Co-authored-by: Julien Marrec <[email protected]> * Revert "Remove parser dependency and prep for 0.9.7 (#226)" This reverts commit a64c11c. * Remove parser and prep for v0.9.7 (#227) * Refactor gemspec to streamline file listing and remove unused parser dependency * Update gemspec to use Dir.glob for file listing and remove unused git command * Prep for 0.9.7 release --------- Co-authored-by: Katherine Fleming <[email protected]> Co-authored-by: Assistant Bot <[email protected]> Co-authored-by: Julien Marrec <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update version to 0.9.5
Update CHANGELOG.md and README.md
Add rubocop-performance to gemspec
prep version 0.9.4
fix: update rubygems source to HTTPS and add gemspec file listing fallback.