Conversation
Will at least add back ext gem setup to work for rc or final version.
Replace OsLib_HelperMethod calls with new runner methods
@mdahlhausen can you take a look at envelope section standards updates. Everything runs and populates tables, but wanted to make sure I used new methods properly.
XcelQAQC test model is failing in E+ need to investigate that. It is only test on that measure
This still uses the resources files with the measure. Hit some issue trying to remove those and only use standards. Should fully update and delete resource files. This will make it easier to maintain and keep it current.
Hoping it will fix the dashboard
Fix issue but hit another one now
have branch in standards that also adds this.
This will allow it to run with 3.8. The older version of the measure with resources files still passes test but the new code standards files on assert for expected values. If can't address than can revert the measure for now.
| spec.add_dependency 'bundler', '>= 2.1' | ||
| spec.add_dependency 'openstudio-extension', '~> 0.7.0' | ||
| spec.add_dependency 'openstudio-standards', '~> 0.5.0' | ||
| spec.add_dependency 'bundler', '~> 2.4.10' |
There was a problem hiding this comment.
Can you make bundler less restrictive 'bundler', '~> 2.4'? The same goes for any other dependency, it would be best to be as open as possible.
The same issue exists in https://github.com/NREL/openstudio-extension-gem/blob/v0.8.0/openstudio-extension.gemspec#L32C1-L33C42, that specifies a different version of bundler. If they could both be 'bundler', '~> 2.4' that would be great.
There was a problem hiding this comment.
@kflemin do you think making this less restrictive will create any issues?
CI failing but local run is fine, this change to test model may be necessary.
DavidGoldwasser
left a comment
DavidGoldwasser
left a comment
There was a problem hiding this comment.
Looks good. I can't approve, only comment on this.
DavidGoldwasser
left a comment
DavidGoldwasser
left a comment
There was a problem hiding this comment.
Looks good. I can only comment on this not approve
5 participants
Current Failing Tests
XcelEDAReportingandQAQC: 1 test error 1 skipped (NoMethodError: undefined method `SqlFilemake_qaqc_results_vector' for OpenstudioStandards:Module) (check with Matt if this changed)
** Severe ** For autosizing of AirTerminal:SingleDuct:ParallelPIU:Reheat AIR TERMINAL SINGLE DUCT PARALLEL PIU REHEAT 2, a zone sizing run must be done.(fixed by updating file to do sizing)execAndReturnFirstDouble' for nil:NilClassfloor_area_query = "SELECT Value FROM tabulardatawithstrings WHERE ReportName='AnnualBuildingUtilityPerformanceSummary' AND ReportForString='Entire Facility' AND TableName='Building Area' AND RowName='Net Conditioned Building Area' AND ColumnName='Area' AND Units='m2'"`1) Failure:
XcelEDAReportingandQAQC_Test#test_example_model [openstudio-common-measures-gem/lib/measures/XcelEDAReportingandQAQC/tests/XcelEDAReportingandQAQC_Test.rb:221]:
Expected an annual peak within 0.5kW of 59.8 but got -999.9.
Expected |59.8 - -999.9| (1059.7) to be <= 0.5.
Pre release