Skip to content

Commit 90d1b62

Browse files
committed
Modify test, since the "" (empty) does work...
see #4205 (comment)
1 parent 72180d1 commit 90d1b62

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/utilities/idf/Test/WorkspaceObject_GTest.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -571,11 +571,12 @@ TEST_F(IdfFixture, WorkspaceObject_setString) {
571571
ASSERT_TRUE(space1.getString(nameIndex));
572572
EXPECT_EQ("Space 1", space1.getString(nameIndex).get());
573573

574-
EXPECT_FALSE(space2.setString(nameIndex, "Space 1"));
574+
EXPECT_TRUE(space2.setString(nameIndex, "Space 1")); // Setting works, but it should modify it
575575
ASSERT_TRUE(space2.getString(nameIndex));
576576
EXPECT_NE("Space 1", space2.getString(nameIndex).get());
577577

578-
EXPECT_FALSE(space2.setString(nameIndex, ""));
578+
// That portion is accepted because the level is Draft, not Final
579+
EXPECT_TRUE(space2.setString(nameIndex, ""));
579580
ASSERT_TRUE(space2.getString(nameIndex));
580-
EXPECT_NE("", space2.getString(nameIndex).get());
581+
EXPECT_EQ("", space2.getString(nameIndex).get());
581582
}

0 commit comments

Comments
 (0)