Skip to content

Followup to #7605 - VRF in airloop/OASys #7773

@rraustad

Description

@rraustad

Issue overview

Several minor details remain for #7605

  • clang-format code after freeze date (or release if that helps reduce conflicts)

  • address issue with Availability Managers used with VRF and UnitarySystem. Zone equipment uses DataHVACGlobals::ZoneCompTurnFansOn/Off and air loop equipment uses DataHVACGlobals::TurnFansOn/Off. These 2 equipment types can be used as zone equipment or air loop equipment so allowing Avail Managers for these equipment is slightly different than most.

  • declare function variables as static const when possible

Update: I don't think this is possible since the sim routine is called from multiple locations and some of these variables are used in one place and others in a different place. So none of these can be const (i.e., they all use the same Sim routine and can't declare these arguments const in the function declaration). However, maybe all of them can be static?

  Ex. MixedAir, OutdoorAirUnit, SimAirServingZones and ZoneEquipmentManger

bool HeatingActive = false;
bool CoolingActive = false;
Real64 OAUCoilOutTemp = 0.0;
bool ZoneEquipFlag = false;
Real64 sensOut = 0.0;
Real64 latOut = 0.0;
OutsideAirSys(OASysNum).compPointer[CompIndex]->simulate(CompName,
                                                                         FirstHVACIteration,
                                                                         AirLoopNum,
                                                                         CompIndex,
                                                                         HeatingActive,
                                                                         CoolingActive,
                                                                         CompIndex,
                                                                         OAUCoilOutTemp,
                                                                         ZoneEquipFlag,
                                                                         sensOut,
                                                                         latOut);

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus (if using an intermediate build, include SHA)
  • Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions