Remove commented-out debug print in QwenProcessor._preprocess_data#88
Open
lonexreb wants to merge 1 commit intoNVlabs:mainfrom
Open
Remove commented-out debug print in QwenProcessor._preprocess_data#88lonexreb wants to merge 1 commit intoNVlabs:mainfrom
lonexreb wants to merge 1 commit intoNVlabs:mainfrom
Conversation
A commented `# print(index, len(image_inputs["image_grid_thw"]))` was left next to the matching `assert index == len(...)` check. The assert already provides the diagnostic information that the print would have shown (it raises with the actual values via the standard assertion message), so the comment is dead and just noise. Pure cleanup. No behavior change. Signed-off-by: lonexreb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A commented-out debug print was left next to the matching assert in
QwenProcessor._preprocess_data:The assert immediately below it already raises with the relevant values when the invariant breaks (Python's standard assertion failure format includes the operands), so the print would not provide any signal a developer can't already get from a normal failure.
Fix
Delete the commented line. One-line removal, no behavior change.