Summary

scripts/download_pai.py passes local_dir_use_symlinks=False to huggingface_hub.snapshot_download. This argument was deprecated in huggingface_hub 0.21 (Feb 2024) and removed in 0.34+, where the call now raises TypeError.

The repo's transitive dependency stack pushes huggingface_hub past the deprecation already (transformers==4.57.1 requires huggingface_hub >= 0.30), so users see a deprecation warning today and will see an outright failure as soon as their environment moves to a newer huggingface_hub.

Why redundant

When local_dir is provided, snapshot_download always copies/writes files directly into that directory (no symlink indirection through the cache). That's the same behavior the now-removed local_dir_use_symlinks=False used to request. Dropping the argument is a no-op for the desired user experience.

Diff

+    # `local_dir_use_symlinks` was deprecated in huggingface_hub 0.21 and
+    # removed in 0.34+; passing it raises TypeError on modern versions. The
+    # current behavior (no symlinks; files are copied/written into local_dir)
+    # is the only option when `local_dir` is provided, so the argument is
+    # redundant — drop it.
     downloaded_path = snapshot_download(
         repo_id=DEFAULT_REPO_ID,
         repo_type="dataset",
         local_dir=str(args.output_dir),
-        local_dir_use_symlinks=False,
         allow_patterns=allow_patterns,
     )

Test plan

• Syntax: ast.parse(open('scripts/download_pai.py').read()) passes.
• No behavior change with the currently installed huggingface_hub: local_dir semantics already produce real files, not symlinks.
• Reviewer: optional — run python scripts/download_pai.py --chunk-ids 0-1 --camera camera_front_wide_120fov --calibration camera_intrinsics --labels egomotion against a recent huggingface_hub install and confirm files land under nvidia/PhysicalAI-Autonomous-Vehicles/.

References

• huggingface_hub release notes for 0.21 (deprecation): https://github.com/huggingface/huggingface_hub/releases/tag/v0.21.0
• Removal in 0.34: https://github.com/huggingface/huggingface_hub/releases (search "local_dir_use_symlinks")