Replace assert with ValueError in create_message()#50
Merged
BorisIvanovic merged 2 commits intoNVlabs:mainfrom Mar 5, 2026
Merged
Replace assert with ValueError in create_message()#50BorisIvanovic merged 2 commits intoNVlabs:mainfrom
BorisIvanovic merged 2 commits intoNVlabs:mainfrom
Conversation
Assert statements can be disabled with python -O flag, which would silently skip validation. Using ValueError ensures the check always runs and provides a clear exception type for callers to handle. Signed-off-by: Dpakkk <[email protected]>
Contributor
Author
|
Related issue: #51 |
BorisIvanovic
approved these changes
Feb 28, 2026
Contributor
BorisIvanovic
left a comment
BorisIvanovic
left a comment
There was a problem hiding this comment.
Thank you very much!
| """Construct the message using images and cot.""" | ||
| assert frames.ndim == 4, f"{frames.ndim=}, expected (N, C, H, W)" | ||
| if frames.ndim != 4: | ||
| raise ValueError(f"frames.ndim={frames.ndim}, expected 4 (N, C, H, W)") |
Contributor
There was a problem hiding this comment.
Suggested change
| raise ValueError(f"frames.ndim={frames.ndim}, expected 4 (N, C, H, W)") | |
| raise ValueError(f"{frames.ndim=}, expected 4 (N, C, H, W)") |
Signed-off-by: Dpakkk <[email protected]>
3 tasks
super-anova
pushed a commit
that referenced
this pull request
May 1, 2026
Assert statements can be disabled with python -O flag, which would silently skip the t0_us validation. Using ValueError ensures the check always runs and provides a clear exception type for callers to handle. Mirrors the pattern of #50 (replace assert with ValueError in create_message). Also includes the computed history_time_range in the error message so callers can see the threshold they violated. Signed-off-by: lonexreb <[email protected]>
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assert statements can be disabled with python -O flag, which would silently skip validation. Using ValueError ensures the check always runs and provides a clear exception type for callers to handle.