Repository navigation
Fix GitArchivePackager when repo or output paths contain spaces - #645
Merged
Merged
Conversation
Signed-off-by: Rio Yu <[email protected]>
Contributor
|
/ok to test 3ecf02c |
Contributor
|
/review |
svcnvidia-nemo-ci
approved these changes
Oct 9, 2026
svcnvidia-nemo-ci
left a comment
Contributor
There was a problem hiding this comment.
No merge-blocking defects found in this light review. Repository discovery expands home-relative paths before quoting, and compression/cleanup quote complete filenames consistently. The six regression cases check archive contents and cleanup across ordinary paths, paths with spaces, and basepath/home-relative overrides.
Validation was static; tests were inspected but not executed.
Review generated by codex
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitArchivePackagerfails when the repository path, job directory or archive name contains spaces. A few shell commands still interpolate these paths without quoting them.This change uses
shlex.quotefor Git path discovery and the final gzip/cleanup commands, following the quoting already used elsewhere in the packager. It also expands~explicitly so home-relative repository paths continue to work after quoting.Repository paths are now treated literally rather than as shell expressions; expand environment variables such as
$HOMEbefore passing them inbasepath.Archive contents and packaging options are unchanged. This is separate from #637, which fixed
PatternPackager; it does not change include-pattern, subpath or submodule handling.Testing
basepathoverride, output directories and archive names with spaces, and a home-relativebasepath./tmpmount because existing unrelated/tmp/exp1state on the host breaks eight NVCRE tests on both main and this branch. The original host file was left untouched.git diff --checkpassed.The full run exits successfully; the installed Ray package still emits a non-failing missing-
ray.dagmessage during interpreter shutdown.