Skip to content

Make functional tests cover examples/converters/* #2259

@yuki-97

Description

@yuki-97

Current State

test_converter_roundtrip.py already covers the core conversion logic, but it has meaningful gaps:

What is covered

  • merge_lora_to_hf() from convert_lora_to_hf.py (called directly via importlib)
  • convert_dcp_to_hf() from nemo_rl.utils.native_checkpoint (the underlying library function)
  • export_model_from_megatron() from nemo_rl.models.megatron.community_import (the underlying library function)

What is NOT covered

  • The CLI entry points of convert_dcp_to_hf.py and convert_megatron_to_hf.py — their parse_args() + main() paths are never exercised
  • convert_lora_to_hf.py's own main() is also not invoked — only the inner function is imported

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions