Skip to content

Add virtual base class HashTableBase#185

Merged
rhdong merged 1 commit into
NVIDIA-Merlin:masterfrom
LinGeLin:add_virtual_base_class
Mar 14, 2024
Merged

Add virtual base class HashTableBase#185
rhdong merged 1 commit into
NVIDIA-Merlin:masterfrom
LinGeLin:add_virtual_base_class

Conversation

@LinGeLin
Copy link
Copy Markdown
Collaborator

Add a virtual base class for more flexibility

@github-actions
Copy link
Copy Markdown

static constexpr auto& thrust_par = thrust::cuda::par;
#endif

template <typename K, typename V, typename S = uint64_t>
Copy link
Copy Markdown
Member

@rhdong rhdong Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment for the HashTableBass class above this line.

@rhdong
Copy link
Copy Markdown
Member

rhdong commented Mar 14, 2024

/blossom-ci

1 similar comment
@rhdong
Copy link
Copy Markdown
Member

rhdong commented Mar 14, 2024

/blossom-ci

Copy link
Copy Markdown
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit d42901f into NVIDIA-Merlin:master Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants