Skip to content

[Opt] optimize kernels of find_or_insert, insert_or_assign, hybrid mode.#164

Merged
rhdong merged 2 commits into
NVIDIA-Merlin:masterfrom
jiashuy:master
Oct 11, 2023
Merged

[Opt] optimize kernels of find_or_insert, insert_or_assign, hybrid mode.#164
rhdong merged 2 commits into
NVIDIA-Merlin:masterfrom
jiashuy:master

Conversation

@jiashuy
Copy link
Copy Markdown
Collaborator

@jiashuy jiashuy commented Aug 29, 2023 •
edited
Loading

  • Optimize find_or_insert, insert_or_assign on HBM mode using pipeline and thread parallelism.
  • Optimize all Hybrid kernels using digests based filter.
  • Others:
    • Fix the value diff error on hybrid mode
      • Enable values check on hybrid mode.
    • Support Sm70 for find_or_insert, insert_or_assign when selecting kernels.
    • Adaptation to new evict strategies.
    • Update the benckmark result at ReadMe.md.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 29, 2023

Documentation preview

https://nvidia-merlin.github.io/HierarchicalKV/review/pr-164

@jiashuy jiashuy force-pushed the master branch 2 times, most recently from cb32151 to cd7ca2e Compare September 22, 2023 16:42
@jiashuy jiashuy changed the title [Opt] optimize find_or_insert API on pure HBM mode. [Opt] optimize kernels of find_or_insert, insert_or_assign, hybrid mode. Sep 22, 2023
@jiashuy jiashuy requested a review from rhdong September 25, 2023 01:23
@rhdong
Copy link
Copy Markdown
Member

rhdong commented Sep 25, 2023

/blossom-ci

rhdong
rhdong reviewed Sep 25, 2023
View reviewed changes
Comment thread include/merlin/core_kernels/find_or_insert.cuh
rhdong
rhdong reviewed Sep 25, 2023
View reviewed changes
Comment thread include/merlin/core_kernels/find_or_insert.cuh Outdated
rhdong
rhdong reviewed Sep 25, 2023
View reviewed changes
Comment thread tests/find_or_insert_test.cc.cu Outdated
rhdong
rhdong reviewed Sep 25, 2023
View reviewed changes
Comment thread include/merlin/core_kernels/find_or_insert.cuh Outdated
@rhdong
Copy link
Copy Markdown
Member

rhdong commented Sep 25, 2023

/blossom-ci

@jiashuy jiashuy mentioned this pull request Sep 25, 2023
Closed
@rhdong
Copy link
Copy Markdown
Member

rhdong commented Oct 11, 2023

/blossom-ci

rhdong
rhdong approved these changes Oct 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit 2cb38b6 into NVIDIA-Merlin:master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhdong rhdong rhdong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jiashuy @rhdong