Skip to content

fix(fern): add multi-source to enable global theme JS assets#340

Merged
dmitsh merged 2 commits into
NVIDIA:mainfrom
pdmack:fix/fern-multi-source
May 20, 2026
Merged

fix(fern): add multi-source to enable global theme JS assets#340
dmitsh merged 2 commits into
NVIDIA:mainfrom
pdmack:fix/fern-multi-source

Conversation

@pdmack

@pdmack pdmack commented May 20, 2026

Copy link
Copy Markdown
Contributor

Description

The global theme's JS bundle (theme_asset_5.js) — which includes the OneTrust cookie consent SDK — is not loaded without multi-source: true on the instance. Only the CSS portion of the global theme is applied.

Cross-referenced all NVIDIA Fern sites:

Repo multi-source theme_asset_5.js loaded
NeMo Curator yes yes
NVCF yes yes
NVSentinel no no
AICR no no
Topograph no no

After merge, trigger the Publish Fern Docs workflow to republish.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • All commits are signed off per DCO (git commit -s).

Without multi-source: true, Fern only applies the global theme's CSS
but not its JS bundle (theme_asset_5.js), which includes the OneTrust
cookie consent SDK. Confirmed by cross-referencing all NVIDIA Fern
sites: only those with multi-source load theme_asset_5.js.

Signed-off-by: Pete MacKinnon <[email protected]>
@pdmack pdmack requested a review from dmitsh as a code owner May 20, 2026 23:08
@greptile-apps

greptile-apps Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Enables the global NVIDIA theme's JavaScript bundle (theme_asset_5.js, which includes the OneTrust cookie-consent SDK) by setting multi-source: true on the Fern docs instance. Also removes the now-unused BadgeLinks.tsx component.

  • fern/docs.yml: Adds multi-source: true to the instance block; without this flag, Fern only applied the CSS portion of the global theme while silently skipping the JS assets.
  • fern/components/BadgeLinks.tsx: Deletes the component entirely — confirmed no references remain in the repository.

Confidence Score: 5/5

A one-line config addition to a YAML file and a dead-code deletion — no runtime logic is touched.

The change is limited to adding a single multi-source: true flag in the Fern docs config and deleting an unreferenced React component. The flag's effect is on the docs publishing pipeline only, and the deletion has no remaining callers in the repo.

No files require special attention.

Important Files Changed

Filename Overview
fern/docs.yml Adds multi-source: true to the Fern instance config, enabling the global theme JS bundle (including OneTrust cookie consent) to load alongside the existing CSS.
fern/components/BadgeLinks.tsx Component deleted with no remaining references in the codebase — clean removal.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Fern Docs Build] --> B{multi-source: true?}
    B -- No --> C[Load Global Theme CSS only]
    B -- Yes --> D[Load Global Theme CSS]
    D --> E[Load theme_asset_5.js]
    E --> F[OneTrust Cookie Consent SDK active]
    C --> G[OneTrust SDK NOT loaded ❌]
Loading

Reviews (2): Last reviewed commit: "chore(fern): remove unused BadgeLinks co..." | Re-trigger Greptile

BadgeLinks.tsx is not referenced by any docs page and the experimental
mdx-components config was removed with the global theme migration.

Signed-off-by: Pete MacKinnon <[email protected]>
@github-actions

Copy link
Copy Markdown
Contributor

@dmitsh dmitsh merged commit b466504 into NVIDIA:main May 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants