Skip to content

feat(fern): adopt global-theme nvidia, remove per-repo theme assets#339

Merged
dmitsh merged 1 commit into
NVIDIA:mainfrom
pdmack:feat/fern-global-theme
May 20, 2026
Merged

feat(fern): adopt global-theme nvidia, remove per-repo theme assets#339
dmitsh merged 1 commit into
NVIDIA:mainfrom
pdmack:feat/fern-global-theme

Conversation

@pdmack

@pdmack pdmack commented May 20, 2026

Copy link
Copy Markdown
Contributor

Description

Switch from per-repo custom theme to Fern's shared global-theme: nvidia. Net deletion: 7 files touched, 5 deleted entirely (-1105 lines).

Follows the pattern established in NVCF (gitlab MR 223) and being adopted across NVIDIA Fern repos.

Deleted (now provided by the global theme):

  • fern/assets/NVIDIA_dark.svg, NVIDIA_light.svg, NVIDIA_symbol.svg
  • fern/components/CustomFooter.tsx
  • fern/main.css

Removed from docs.yml (replaced by global-theme: nvidia):

  • footer:, layout:, colors:, theme:, logo: image paths, favicon:, js:, css:, experimental: blocks

Kept: logo.href + logo.right-text, navbar-links, BadgeLinks.tsx

Fern CLI: bumped from 4.42.1 to 5.30.2 (required for global-theme support)

Validated with fern check and local fern docs dev preview.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • All commits are signed off per DCO (git commit -s).

Switch from per-repo custom theme to Fern global-theme: nvidia.
Bump Fern CLI from 4.42.1 to 5.30.2 (required for global-theme).

Deleted (now provided by the global theme):
- fern/assets/NVIDIA_dark.svg, NVIDIA_light.svg, NVIDIA_symbol.svg
- fern/components/CustomFooter.tsx
- fern/main.css

Removed from docs.yml (replaced by global-theme: nvidia):
- footer, layout, colors, theme, logo image paths, favicon, js, css,
  experimental blocks

Kept: logo.href + logo.right-text, navbar-links, BadgeLinks.tsx.
Signed-off-by: Pete MacKinnon <[email protected]>
@pdmack pdmack requested a review from dmitsh as a code owner May 20, 2026 18:42
@github-actions

Copy link
Copy Markdown
Contributor

@greptile-apps

greptile-apps Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR migrates the Topograph Fern docs from a per-repo custom theme (inline CSS, React footer component, local SVG assets, JS analytics block) to Fern's shared global-theme: nvidia, and bumps the Fern CLI from 4.42.1 to 5.30.2 to enable that feature. The net result is a deletion of five files and ~1100 lines of bespoke theming configuration.

  • Deleted: NVIDIA_dark.svg, NVIDIA_light.svg, NVIDIA_symbol.svg, CustomFooter.tsx, main.css — all now provided centrally by the global theme.
  • docs.yml simplified: footer, layout, colors, theme, logo image paths, favicon, js, css, and experimental blocks removed; logo.href, logo.right-text, and navbar-links retained.
  • BadgeLinks.tsx is now an orphan: the experimental.mdx-components registration and the .badge-links CSS it depends on are both gone; no MDX file currently uses it, so there is no production break, but the file is non-functional as-is.

Confidence Score: 4/5

Safe to merge; changes are pure deletions and configuration simplification with no functional logic code touched.

The change is straightforward infrastructure cleanup — local theme assets, CSS, and a custom footer React component are deleted and replaced by a shared global theme. The fern check and local dev preview validations give reasonable confidence the Fern v5 migration is correct. Two non-blocking concerns remain: BadgeLinks.tsx is now unregistered and its CSS dependency is gone (though no MDX page currently uses it), and the Adobe DTM analytics script was removed without explicit confirmation that the global theme re-injects it centrally.

fern/docs.yml deserves a second look for the dropped Adobe DTM js: block and the removed experimental section; fern/components/BadgeLinks.tsx should either be deleted or properly re-wired for Fern v5.

Important Files Changed

Filename Overview
fern/docs.yml Adopts global-theme: nvidia, removing footer, layout, colors, theme, logo images, favicon, js, css, and experimental blocks; retains logo href/right-text and navbar-links. The experimental.mdx-components registration is removed, leaving BadgeLinks.tsx unregistered.
fern/fern.config.json Fern CLI bumped from 4.42.1 to 5.30.2 (major version jump required for global-theme support). Breaking changes are possible but author validated with fern check and local preview.
fern/components/CustomFooter.tsx Deleted entirely; footer content (NVIDIA logo, privacy/legal links, copyright) now provided by global-theme: nvidia.
fern/main.css Deleted entirely (872 lines). Contains .badge-links rule referenced in BadgeLinks.tsx; if that component is used in the future, the CSS must be provided elsewhere (e.g., the global theme or a new css file).
fern/assets/NVIDIA_dark.svg Deleted; logo assets now provided by global-theme: nvidia.
fern/assets/NVIDIA_light.svg Deleted; logo assets now provided by global-theme: nvidia.
fern/assets/NVIDIA_symbol.svg Deleted; favicon/symbol now provided by global-theme: nvidia.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Before["Before (Fern 4.42.1 – per-repo theme)"]
        A[docs.yml] --> B[main.css]
        A --> C[CustomFooter.tsx]
        A --> D[NVIDIA_dark/light/symbol.svg]
        A --> E[Adobe DTM JS script]
        A --> F[experimental: mdx-components]
        F --> G[BadgeLinks.tsx]
    end

    subgraph After["After (Fern 5.30.2 – global-theme)"]
        H[docs.yml] -->|global-theme: nvidia| I[Fern global-theme: nvidia]
        I --> J[Central CSS / theme]
        I --> K[Central footer]
        I --> L[Central logo/favicon assets]
        H --> M[logo.href + right-text]
        H --> N[navbar-links / redirects]
        O[BadgeLinks.tsx] -.->|unregistered, unused| X((orphaned))
    end

    Before -.->|Migration| After
Loading

Reviews (1): Last reviewed commit: "feat(fern): adopt global-theme nvidia, r..." | Re-trigger Greptile

Comment thread fern/docs.yml
Comment on lines 41 to 43
navbar-links:
- type: github
value: https://github.com/NVIDIA/topograph

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Adobe DTM analytics script silently dropped

The removed js: block loaded https://assets.adobedtm.com/5d4962a43b79/c1061d2c5e7b/launch-191c2462b890.min.js with strategy: beforeInteractive. If the global-theme: nvidia does not inject this script centrally, analytics events will stop firing for this docs site after the change lands. Worth confirming explicitly with the NVCF team or checking the global theme's asset list before merging.

@dmitsh dmitsh merged commit 02d44d0 into NVIDIA:main May 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants