feat(fern): adopt global-theme nvidia, remove per-repo theme assets#339
Conversation
Switch from per-repo custom theme to Fern global-theme: nvidia. Bump Fern CLI from 4.42.1 to 5.30.2 (required for global-theme). Deleted (now provided by the global theme): - fern/assets/NVIDIA_dark.svg, NVIDIA_light.svg, NVIDIA_symbol.svg - fern/components/CustomFooter.tsx - fern/main.css Removed from docs.yml (replaced by global-theme: nvidia): - footer, layout, colors, theme, logo image paths, favicon, js, css, experimental blocks Kept: logo.href + logo.right-text, navbar-links, BadgeLinks.tsx. Signed-off-by: Pete MacKinnon <[email protected]>
Greptile SummaryThis PR migrates the Topograph Fern docs from a per-repo custom theme (inline CSS, React footer component, local SVG assets, JS analytics block) to Fern's shared
Confidence Score: 4/5Safe to merge; changes are pure deletions and configuration simplification with no functional logic code touched. The change is straightforward infrastructure cleanup — local theme assets, CSS, and a custom footer React component are deleted and replaced by a shared global theme. The
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Before["Before (Fern 4.42.1 – per-repo theme)"]
A[docs.yml] --> B[main.css]
A --> C[CustomFooter.tsx]
A --> D[NVIDIA_dark/light/symbol.svg]
A --> E[Adobe DTM JS script]
A --> F[experimental: mdx-components]
F --> G[BadgeLinks.tsx]
end
subgraph After["After (Fern 5.30.2 – global-theme)"]
H[docs.yml] -->|global-theme: nvidia| I[Fern global-theme: nvidia]
I --> J[Central CSS / theme]
I --> K[Central footer]
I --> L[Central logo/favicon assets]
H --> M[logo.href + right-text]
H --> N[navbar-links / redirects]
O[BadgeLinks.tsx] -.->|unregistered, unused| X((orphaned))
end
Before -.->|Migration| After
Reviews (1): Last reviewed commit: "feat(fern): adopt global-theme nvidia, r..." | Re-trigger Greptile |
| navbar-links: | ||
| - type: github | ||
| value: https://github.com/NVIDIA/topograph |
There was a problem hiding this comment.
Adobe DTM analytics script silently dropped
The removed js: block loaded https://assets.adobedtm.com/5d4962a43b79/c1061d2c5e7b/launch-191c2462b890.min.js with strategy: beforeInteractive. If the global-theme: nvidia does not inject this script centrally, analytics events will stop firing for this docs site after the change lands. Worth confirming explicitly with the NVCF team or checking the global theme's asset list before merging.
Description
Switch from per-repo custom theme to Fern's shared
global-theme: nvidia. Net deletion: 7 files touched, 5 deleted entirely (-1105 lines).Follows the pattern established in NVCF (gitlab MR 223) and being adopted across NVIDIA Fern repos.
Deleted (now provided by the global theme):
fern/assets/NVIDIA_dark.svg,NVIDIA_light.svg,NVIDIA_symbol.svgfern/components/CustomFooter.tsxfern/main.cssRemoved from
docs.yml(replaced byglobal-theme: nvidia):footer:,layout:,colors:,theme:,logo:image paths,favicon:,js:,css:,experimental:blocksKept:
logo.href+logo.right-text,navbar-links,BadgeLinks.tsxFern CLI: bumped from
4.42.1to5.30.2(required forglobal-themesupport)Validated with
fern checkand localfern docs devpreview.Checklist
git commit -s).