Skip to content

build: add make qualify pre-push aggregator#256

Merged
dmitsh merged 1 commit into
NVIDIA:mainfrom
resker:chore/make-qualify-target
Apr 17, 2026
Merged

build: add make qualify pre-push aggregator#256
dmitsh merged 1 commit into
NVIDIA:mainfrom
resker:chore/make-qualify-target

Conversation

@resker

@resker resker commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds a qualify target to the Makefile that runs the full local quality check battery in sequence: fmt, vet, lint, test.

.PHONY: qualify
qualify: fmt vet lint test
	@echo "All quality checks passed."

Why

Reduces the pre-push ceremony from four separate commands to one. Makes AGENTS.md and CONTRIBUTING.md able to cite a single canonical pre-push command. Matches the convention already established in other NVIDIA OSS repos (e.g., AICR).

No new checks are introduced — this is purely a convenience aggregator over existing targets.

Test plan

  • make -n qualify dry-runs the expected sequence (fmt → vet → lint → test → success echo)
  • All four constituent targets already exist and pass in CI on main

Adds a `qualify` target that runs fmt, vet, lint, and test in sequence —
the full local quality check battery. Reduces the pre-push ceremony to
a single command and gives AGENTS.md / CONTRIBUTING.md a concise ask
for contributors.

No new checks; purely a convenience aggregator over existing targets.

Signed-off-by: Rob Esker <[email protected]>
@greptile-apps

greptile-apps Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a qualify phony Makefile target that chains the existing fmt, vet, lint, and test targets into a single pre-push command, printing a success message if all four pass. No new checks are introduced; this is purely a convenience aggregator.

Confidence Score: 5/5

Safe to merge — adds a simple convenience aggregator target with no new logic or risk.

All findings are P2 or lower. The change is a three-line Makefile addition that correctly declares a phony target and delegates entirely to already-tested prerequisites.

No files require special attention.

Important Files Changed

Filename Overview
Makefile Adds .PHONY: qualify target that sequences fmt → vet → lint → test; straightforward and correct aggregator with no logic issues.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    Q([make qualify]) --> F[fmt\ngo fmt ./...]
    F --> V[vet\ngo vet ./...]
    V --> L[lint\ngolangci-lint run --new-from-rev ...]
    L --> T[test\ngo test -race ./...]
    T --> E[echo: All quality checks passed.]
    F -- failure --> FAIL([❌ make exits])
    V -- failure --> FAIL
    L -- failure --> FAIL
    T -- failure --> FAIL
Loading

Reviews (1): Last reviewed commit: "build: add make qualify pre-push aggrega..." | Re-trigger Greptile

@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.46%. Comparing base (1875ab8) to head (4eea2b2).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   68.46%   68.46%           
=======================================
  Files          82       82           
  Lines        4842     4842           
=======================================
  Hits         3315     3315           
  Misses       1395     1395           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmitsh dmitsh merged commit 63fe1e8 into NVIDIA:main Apr 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants