build: add make qualify pre-push aggregator#256
Conversation
Adds a `qualify` target that runs fmt, vet, lint, and test in sequence — the full local quality check battery. Reduces the pre-push ceremony to a single command and gives AGENTS.md / CONTRIBUTING.md a concise ask for contributors. No new checks; purely a convenience aggregator over existing targets. Signed-off-by: Rob Esker <[email protected]>
Greptile SummaryAdds a Confidence Score: 5/5Safe to merge — adds a simple convenience aggregator target with no new logic or risk. All findings are P2 or lower. The change is a three-line Makefile addition that correctly declares a phony target and delegates entirely to already-tested prerequisites. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
Q([make qualify]) --> F[fmt\ngo fmt ./...]
F --> V[vet\ngo vet ./...]
V --> L[lint\ngolangci-lint run --new-from-rev ...]
L --> T[test\ngo test -race ./...]
T --> E[echo: All quality checks passed.]
F -- failure --> FAIL([❌ make exits])
V -- failure --> FAIL
L -- failure --> FAIL
T -- failure --> FAIL
Reviews (1): Last reviewed commit: "build: add make qualify pre-push aggrega..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage 68.46% 68.46%
=======================================
Files 82 82
Lines 4842 4842
=======================================
Hits 3315 3315
Misses 1395 1395
Partials 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Adds a
qualifytarget to the Makefile that runs the full local quality check battery in sequence:fmt,vet,lint,test.Why
Reduces the pre-push ceremony from four separate commands to one. Makes AGENTS.md and CONTRIBUTING.md able to cite a single canonical pre-push command. Matches the convention already established in other NVIDIA OSS repos (e.g., AICR).
No new checks are introduced — this is purely a convenience aggregator over existing targets.
Test plan
make -n qualifydry-runs the expected sequence (fmt → vet → lint → test → success echo)