Skip to content

allow to build arch-specific packages#120

Merged
dmitsh merged 1 commit into
mainfrom
ds-make
Jun 5, 2025
Merged

allow to build arch-specific packages#120
dmitsh merged 1 commit into
mainfrom
ds-make

Conversation

@dmitsh

@dmitsh dmitsh commented Jun 5, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Dmitry Shmulevich <[email protected]>
@dmitsh dmitsh requested a review from sanjaychatterjee as a code owner June 5, 2025 00:05
@dmitsh dmitsh merged commit f607d31 into main Jun 5, 2025
4 checks passed
@dmitsh dmitsh deleted the ds-make branch June 5, 2025 00:06
@codecov

codecov Bot commented Jun 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.35%. Comparing base (d959e97) to head (c49a318).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   64.35%   64.35%           
=======================================
  Files          64       64           
  Lines        4046     4046           
=======================================
  Hits         2604     2604           
  Misses       1332     1332           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

resker added a commit to resker/topograph that referenced this pull request Apr 17, 2026
The companion NVSentinel PR is not being filed at this time; removing
the dormant-link trailer lets the NVSentinel integration section stand
on its own as a self-contained reference.

Signed-off-by: Rob Esker <[email protected]>
dmitsh pushed a commit that referenced this pull request Apr 19, 2026
…nce (#254)

* docs(reference): add node labels and annotations reference

Documents all Kubernetes node labels and annotations set by Topograph,
including the four network.topology.nvidia.com/ labels written by the k8s
and slinky engines, the topograph.nvidia.com/ annotation keys, FNV-64a
hash truncation behavior for long values, and an NVSentinel integration
example.

Closes #179

Signed-off-by: Rob Esker <[email protected]>

* docs(reference): add gpu.clique relationship and non-MNNVL context to node-labels

- Clarify accelerator value format per provider: IB providers use
  ClusterUUID.CliqueId (same as nvidia.com/gpu.clique), NetQ uses
  NMX DomainUUID (different identifier format)
- Add note that gpu.clique is not set on non-MNNVL systems and
  Topograph is the only topology source in those environments
- Add nvidia.com/gpu.clique to the "Without Topograph" label table

Signed-off-by: Rob Esker <[email protected]>

* docs(reference): drop trailing NVSentinel issue #120 reference

The companion NVSentinel PR is not being filed at this time; removing
the dormant-link trailer lets the NVSentinel integration section stand
on its own as a self-contained reference.

Signed-off-by: Rob Esker <[email protected]>

* docs(reference): note x-prefix on FNV-64a hash label values

The hash is rendered as fmt.Sprintf("x%x", h.Sum64()) in
pkg/engines/k8s/labeler.go:checkLabel, producing an x-prefixed lowercase
hex string. Previous wording said 'hex-encoded' without the prefix,
which matters for operators parsing or filtering label values.

Signed-off-by: Rob Esker <[email protected]>

* docs(reference): add lambdai and cw to the provider matrix

Addresses Greptile's P1 finding on #254. Both are registered providers
that write topology labels but were missing from the matrix:

- lambdai: emits ClusterUUID.CliqueID-style accelerator via
  NVLink.DomainID + NVLink.CliqueID, plus tree labels via
  ToThreeTierGraph (pkg/providers/lambdai/instance_topology.go)
- cw: calls ib.GenerateTopologyConfig and wraps the output as a bare
  tree root (pkg/providers/cw/provider.go), emitting tree labels only

Signed-off-by: Rob Esker <[email protected]>

* docs(reference): fix broken engine links and correct cw tree column

Two fixes from the PR #254 review:

- Fern Check was failing because lines 7 points at `../engines.md`,
  which is not a single file — `docs/engines/` is a directory with
  per-engine files. Fixed the Kubernetes and Slinky engine links to
  point at `../engines/k8s.md` and `../engines/slinky.md`
  respectively.

- Greptile's latest P1 finding is correct: `cw.GenerateTopologyConfig`
  returns a tree root whose children are switch IDs directly, not
  wrapped under `topology.TopologyTree`. Both the k8s labeler
  (`ApplyNodeLabels`, `labeler.go:77`) and Slinky's `initTree`
  (`translate/topology.go:118`) gate processing on
  `root.Vertices[topology.TopologyTree]`, which is never present in
  cw's output. Compare with `netq/provider.go:92` which correctly
  wraps `root.Vertices[topology.TopologyTree] = treeRoot`. The cw
  provider emits zero labels today; updated the matrix row to
  reflect current behavior with a note about the underlying issue.

Signed-off-by: Rob Esker <[email protected]>

---------

Signed-off-by: Rob Esker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant