Skip to content

Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 - #2517

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:branch-25.02from
bdice:relax-cuda-python-upper-bound
Dec 5, 2024
Merged

rapids-bot[bot] merged 4 commits into
NVIDIA:branch-25.02from
bdice:relax-cuda-python-upper-bound

Conversation

@bdice

@bdice bdice commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

Now that some upstream bugs have been fixed, we can allow cuda-python 12.6.2 and 11.8.5.

See NVIDIA/cuda-python#226 (comment) for more information.

@bdice bdice added non-breaking Non-breaking change feature request New feature or request labels Dec 4, 2024
@copy-pr-bot

copy-pr-bot Bot commented Dec 4, 2024

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice
bdice marked this pull request as ready for review December 4, 2024 05:32
@bdice
bdice requested a review from a team as a code owner December 4, 2024 05:32
@bdice
bdice requested a review from KyleFromNVIDIA December 4, 2024 05:32
@jameslamb
jameslamb requested review from jameslamb and removed request for KyleFromNVIDIA December 4, 2024 17:50
@bdice
bdice requested a review from a team as a code owner December 4, 2024 18:17
Comment thread dependencies.yaml
- nccl>=2.19
- libucxx==0.42.*,>=0.0.0a0
- nccl>=2.19
- spdlog>=1.14.1,<1.15

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spdlog was missing in RAFT conda devcontainers. Previously it was gotten transitively from RMM but that was removed in rapidsai/rmm#1739, causing a build failure. I discussed with @vyasr and we agreed this fix (adding spdlog) is necessary for the short term. In the medium-to-long term, @vyasr is going to rework the loggers.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for summarizing that here, works for me.

(and thanks for alphabetizing this list while you're touching it).

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding a spdlog dependency for now sounds good to me, thanks.

@bdice

bdice commented Dec 4, 2024

Copy link
Copy Markdown
Contributor Author

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake cpp feature request New feature or request non-breaking Non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants