Repository navigation
fix: discover the MPS pipe directory for IPC mounts - #2143
Merged
Merged
Conversation
The IPC discoverer located /tmp/nvidia-mps with a file locator. The file locator's default filter rejects directories, so the MPS pipe directory was never found and no mount was emitted for it. Use a directory locator for the MPS pipe directory. The socket lookup is unchanged and the IPC mount options are kept. Signed-off-by: Evan Lezar <[email protected]>
Coverage Report for CI Build 38594403494Coverage increased (+0.3%) to 45.083%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
elezar
marked this pull request as ready for review
October 14, 2026 19:29
elezar
requested review from
cdesiniotis,
henry118 and
tariq1890
as code owners
October 14, 2026 19:29
9 of 13 tasks
tariq1890
approved these changes
Oct 14, 2026
cdesiniotis
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NewIPCDiscovererintends to mount the MPS pipe directory (/tmp/nvidia-mps) alongside the persistenced and fabricmanager sockets, but it located it with a file locator. The file locator's default filter (assertFile) rejects directories, and the miss is only logged at debug level, so the MPS pipe directory was never found and no mount was emitted for it in generated CDI specs or the runtime's automatic CDI modifications.This change uses the existing directory locator for the MPS pipe directory. The socket lookup and the IPC mount options (
nosuid,nodev,rbind,rprivate,noexec) are unchanged.The legacy (libnvidia-container) path is not affected; it already locates the MPS pipe directory in
nvc_info.c.Known gaps, not addressed here:
CUDA_MPS_PIPE_DIRECTORY; the Go discoverer still only checks/tmp/nvidia-mps./tmpand may still not be found.Checklist
make test)make lint)Testing
TestNewIPCDiscoverer, a table test over a temporary driver root covering: no IPC paths present, the MPS directory (emitted with the IPC mount options), a regular file at the MPS path (ignored), sockets under/runand/var/run, socket paths that are directories (ignored), and sockets together with MPS. The MPS case fails with the previous file locator.go test ./internal/discover/... ./pkg/lookup/...,go vet, andgolangci-lint runon the touched packages pass.🤖 Generated with Claude Code