Skip to content

Revert "Bump the actions-monthly group across 1 directory with 5 updates" - #134

Merged
leofang merged 1 commit into
mainfrom
revert-125-dependabot/github_actions/actions-monthly-cd8997c8ed
Jun 13, 2026
Merged

leofang merged 1 commit into
mainfrom
revert-125-dependabot/github_actions/actions-monthly-cd8997c8ed

Conversation

@leofang

@leofang leofang commented Jun 13, 2026

Copy link
Copy Markdown
Member

Reverts #125

The Windows build failed with the latest cibuildwheel, but we did not update the status check to include Windows pipelines, so automerge ignored the failures and merged away.

@copy-pr-bot

copy-pr-bot Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang

leofang commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

Admin-merge to keep the main branch healthy.

@leofang
leofang merged commit 34753ee into main Jun 13, 2026
1 check passed
@leofang
leofang deleted the revert-125-dependabot/github_actions/actions-monthly-cd8997c8ed branch June 13, 2026 00:04
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang

leofang commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

The Windows build failed with the latest cibuildwheel, but we did not update the status check to include Windows pipelines, so automerge ignored the failures and merged away.

Turns out it's way more subtle than I originally anticipated, see RCCA: NVIDIA/cuda-python#2208

leofang added a commit to leofang/numba-cuda-mlir that referenced this pull request Jun 16, 2026
cibuildwheel v4 made `delvewheel repair -w {dest_dir} -v {wheel}` the
default for `CIBW_REPAIR_WHEEL_COMMAND_WINDOWS`; v3.x had no default. We
intentionally do not need wheel repair on Windows because the wheel is
built with `/MT` (static CRT) per NVIDIA#127 -- it is self-contained and has
no DLL dependencies for delvewheel to bundle.

Without this opt-out, the default delvewheel invocation discovers an
unresolvable reference to the project's own internal nanobind module
and fails wheel build for every win-64 matrix entry. This regression
re-surfaced when the cibuildwheel v3.4.1 -> v4.1.0 bump from NVIDIA#125 was
cherry-picked into this branch to validate the new aggregator catches
it. With the opt-out, the build succeeds again.

Refs: NVIDIA#127 (static-CRT Windows wheel design), NVIDIA#125 / NVIDIA#134 (original
cibuildwheel bump + revert).
atmnp added a commit that referenced this pull request Jun 23, 2026
* ci: adopt CCCL check_result aggregator and add [doc-only] PR mode

Mirrors the gating-check fix in NVIDIA/cuda-python#2210 (root-cause
analysis: NVIDIA/cuda-python#2208) and bundles in cuda-python's
`[doc-only]` PR-mode feature, which had not been propagated to this
repo.

Changes:

* should-skip: emit both `skip` (existing `[no-ci]` gate) and a new
  `doc_only` output, computed from PR title containing `[doc-only]`.
  Single `gh pr view` call now drives both, matching cuda-python's
  pattern.

* `[doc-only]` gating on non-doc-chain jobs: build-llvm-linux-aarch64,
  build-llvm-windows, build-linux-aarch64, build-windows, and all 11
  test-* jobs now have
  `&& \!fromJSON(needs.should-skip.outputs.doc-only)` in their `if:`.
  The linux-64 chain (build-llvm-linux-64, build-linux-64) and
  build-docs are intentionally NOT `[doc-only]`-gated because
  build-docs needs the linux-64 wheel.

* checks: aggregator rewritten to CCCL's `check_result` pattern:
  explicit `expected="success"` per dependency, anything else
  (including `'skipped'` from a failed upstream) fails the gate.
  `[no-ci]` short-circuits at the top; `[doc-only]` flips `expected`
  to `"skipped"` for every test-* dep. `should-skip` itself is now in
  `needs:` and checked, so a crash in the gating job can't masquerade
  as a green CI run.

Verified the aggregator script with a local simulation across 8
scenarios: normal-green, build-fail-cascade, `[no-ci]`,
`[doc-only]`-OK, `[doc-only]`-doc-fails, build-windows-fail-cascade,
single-test-fail, should-skip-itself-fails. All behave correctly.

Reference: CCCL gate,
https://github.com/NVIDIA/cccl/blob/8c0e6cb1b6412d7bd0070f9ac3f55fa80231961a/.github/workflows/ci-workflow-pull-request.yml#L463-L526

Refs: NVIDIA/cuda-python#2208, NVIDIA/cuda-python#2210

* Bump the actions-monthly group across 1 directory with 5 updates (#125)

Bumps the actions-monthly group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) | `8.1.0` | `8.2.0` |
| [github/codeql-action](https://github.com/github/codeql-action) | `4.35.3` | `4.36.2` |
| [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) | `3.4.1` | `4.1.0` |
| [prefix-dev/setup-pixi](https://github.com/prefix-dev/setup-pixi) | `0.9.5` | `0.9.6` |
| [test-summary/action](https://github.com/test-summary/action) | `2.4` | `2.6` |



Updates `astral-sh/setup-uv` from 8.1.0 to 8.2.0
- [Release notes](https://github.com/astral-sh/setup-uv/releases)
- [Commits](astral-sh/setup-uv@0880764...fac544c)

Updates `github/codeql-action` from 4.35.3 to 4.36.2
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@e46ed2c...8aad20d)

Updates `pypa/cibuildwheel` from 3.4.1 to 4.1.0
- [Release notes](https://github.com/pypa/cibuildwheel/releases)
- [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md)
- [Commits](pypa/cibuildwheel@8d2b08b...2947353)

Updates `prefix-dev/setup-pixi` from 0.9.5 to 0.9.6
- [Release notes](https://github.com/prefix-dev/setup-pixi/releases)
- [Commits](prefix-dev/setup-pixi@1b2de7f...5185adf)

Updates `test-summary/action` from 2.4 to 2.6
- [Release notes](https://github.com/test-summary/action/releases)
- [Commits](test-summary/action@v2.4...v2.6)

---
updated-dependencies:
- dependency-name: astral-sh/setup-uv
  dependency-version: 8.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions-monthly
- dependency-name: github/codeql-action
  dependency-version: 4.36.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions-monthly
- dependency-name: prefix-dev/setup-pixi
  dependency-version: 0.9.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions-monthly
- dependency-name: pypa/cibuildwheel
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions-monthly
- dependency-name: test-summary/action
  dependency-version: '2.6'
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions-monthly
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ci: opt out of delvewheel repair on Windows (cibuildwheel v4 default)

cibuildwheel v4 made `delvewheel repair -w {dest_dir} -v {wheel}` the
default for `CIBW_REPAIR_WHEEL_COMMAND_WINDOWS`; v3.x had no default. We
intentionally do not need wheel repair on Windows because the wheel is
built with `/MT` (static CRT) per #127 -- it is self-contained and has
no DLL dependencies for delvewheel to bundle.

Without this opt-out, the default delvewheel invocation discovers an
unresolvable reference to the project's own internal nanobind module
and fails wheel build for every win-64 matrix entry. This regression
re-surfaced when the cibuildwheel v3.4.1 -> v4.1.0 bump from #125 was
cherry-picked into this branch to validate the new aggregator catches
it. With the opt-out, the build succeeds again.

Refs: #127 (static-CRT Windows wheel design), #125 / #134 (original
cibuildwheel bump + revert).

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Atmn Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant