Repository navigation
Fix sccache summary to count CUDA sub-tool cache hits - #878
Merged
Merged
Conversation
The rapidsai/sccache fork tracks CUDA compilation sub-phases under separate language keys in the JSON stats: "CUDA" (nvcc driver), "CUDA (Device code)" (cudafe++), "PTX" (cicc), and "CUBIN" (ptxas). The summary script only counted the "CUDA" key, which represents just the top-level nvcc pass and typically shows 0 cache hits. All the actual cache hits land in the sub-tool categories. This caused the step summary to report 0% hit rate even when sccache's own stats showed ~34%. Include all CUDA-related language keys so the reported rate matches sccache's own "Cache hits rate" output.
leofang
marked this pull request as ready for review
May 7, 2026 04:21
This was referenced May 7, 2026
Member
Author
|
/ok to test 140b45b |
Member
Author
|
Admin-merge since this is CI infra-only and does not affect building/testing. |
Merged
kkraus14
added a commit
that referenced
this pull request
Jun 25, 2026
## Summary - Bump the package version to 0.30.3 for the next patch release. ## Changes since v0.30.2 - Add CUDA 13 maintenance notice and pixi build fix (#899) - Fix sccache summary to count CUDA sub-tool cache hits (#878) ## Validation - `python -c "from pathlib import Path; assert Path('numba_cuda/VERSION').read_text().strip() == '0.30.3'; assert 'version = \"0.30.3\"' in Path('pixi.toml').read_text(); print('version files OK')"`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sccache step summary reported 0% cache hit rate even when sccache's own
--show-adv-statsshowed ~34%.The rapidsai/sccache fork tracks CUDA compilation sub-phases under separate language keys in the JSON stats:
"CUDA"— nvcc driver pass"CUDA (Device code)"— cudafe++ pass"PTX"— cicc pass"CUBIN"— ptxas passThe summary script only counted
{"C/C++", "CUDA"}, which captures the nvcc driver pass only. That pass typically has 0 cache hits — the actual hits all land in the sub-tool categories. This PR adds the missing keys so the reported rate matches sccache's own output.Before (from this job):
while sccache reported
Cache hits rate 33.74%.After: would report
33% hit rate (111/329).Test plan
0% (0/91), new logic gives33.74% (111/329), matching sccache's own report.