Skip to content

feat(ci): add support rc releases#236

Merged
lockwobr merged 1 commit into
mainfrom
rc-support
May 18, 2026
Merged

feat(ci): add support rc releases#236
lockwobr merged 1 commit into
mainfrom
rc-support

Conversation

@lockwobr

@lockwobr lockwobr commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds release candidate support to .github/workflows/release.yml for operator/, agent/, and chart/ tags. Tags matching v<MAJOR>.<MINOR>.<PATCH>-rc<N>
    are published with --prerelease so they don't become "Latest" on the Releases page.
  • Validates tag shape in the workflow: only vX.Y.Z and vX.Y.Z-rcN are accepted; any other suffix (-beta, -rc.1, -rc1a, etc.) fails the job with a
    clear error so the tag format stays predictable.
  • CLI release workflow (cli-release.yaml) already auto-detects prereleases via softprops/action-gh-release@v3, so no change there.
  • Documents the RC flow in docs/release-process.md (tag commands, Chart.yaml mirroring requirement, Helm OCI behavior, git cliff --latest scoping).

Checklist

  • I am familiar with the Contributing Guidelines.
  • My commits are signed off (git commit -s) per the DCO.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@lockwobr lockwobr self-assigned this May 18, 2026
@coderabbitai

coderabbitai Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 448c9894-b6b2-4719-8b63-a42b43d875da

📥 Commits

Reviewing files that changed from the base of the PR and between 60fefe0 and 412eed3.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • docs/release-process.md
📝 Walkthrough

Walkthrough

This PR extends the GitHub release workflow to support release candidate (RC) versions with -rc<N> suffixes. The workflow now parses the tag name, validates it matches either v<MAJOR>.<MINOR>.<PATCH> or v<MAJOR>.<MINOR>.<PATCH>-rc<N> format, conditionally applies the --prerelease flag for RC tags, and rejects any other tag format with an error. The release process documentation has been updated with a new section explaining how to cut RC component tags and noting the GitHub prerelease behavior and Helm OCI prerelease install mechanics.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • NVIDIA/nodewright#233: Modifies .github/workflows/release.yml tag handling and validates chart tags against chart/Chart.yaml.

Suggested reviewers

  • mskalka
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding release candidate support to CI workflows, which is the core objective of this PR.
Description check ✅ Passed The description is directly related to the changeset, providing specific details about RC tag support, validation logic, and documentation updates that match the file changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rc-support

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed May 18, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/release-process.md`:
- Line 108: The example chart artifact filename is inconsistent: the diff shows
chart/v0.16.0-rc1 and version: v0.16.0-rc1 but the filename example omits the
leading "v"; update the filename example to include the "v" prefix (e.g., change
skyhook-operator-0.16.0-rc1.tgz to skyhook-operator-v0.16.0-rc1.tgz) so it
matches the documented version format and the install example (--version
v0.16.0-rc1).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: a6b9ae50-f639-4333-9dfe-a9020ba21be8

📥 Commits

Reviewing files that changed from the base of the PR and between 8c58f32 and 60fefe0.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • docs/release-process.md

Comment thread docs/release-process.md Outdated
rice-riley
rice-riley previously approved these changes May 18, 2026
View reviewed changes
@lockwobr lockwobr merged commit 157d5e9 into main May 18, 2026
8 checks passed
@lockwobr lockwobr deleted the rc-support branch May 18, 2026 20:31
This was referenced May 18, 2026
Merged
Merged
@lockwobr lockwobr mentioned this pull request May 22, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@rice-riley rice-riley rice-riley approved these changes
@mskalka mskalka Awaiting requested review from mskalka
@ayuskauskas ayuskauskas Awaiting requested review from ayuskauskas ayuskauskas is a code owner

Assignees

@lockwobr lockwobr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lockwobr @rice-riley