This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix warnings in several headers #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This fixes NVIDIA/cccl#998. I made some effort to find out why that warning wasn't being issued in the first place, and it's because we use The actual fix for NVIDIA/cccl#998 on the other hand is to add the system header pragma to some of the files that need it. Specifically files that implement additional things on top of |
miscco
approved these changes
Feb 18, 2023
Comment on lines
+40
to
+44
| if (NOT MSVC) | ||
| set(LIBCUDACXX_WARNING_LEVEL | ||
| "--compiler-options=-Wall \ | ||
| --compiler-options=-Wextra") | ||
| endif() |
Collaborator
There was a problem hiding this comment.
I am not too happy with this. That said, we can reenable them once we have a workaround in place
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC is extremely pedantic with
/Wallenabled so we'll skip that entirely.