Repository navigation
Conversation
Since "convert device names to capital letters" (3b4d73f, 2022) the plugin registers passthrough GPUs as nvidia.com/<PCI.IDS NAME IN UPPER CASE>, for example nvidia.com/TU104GL_TESLA_T4. The example KubeVirt CR and VMI still use the old mixed-case names (nvidia.com/TU104GL_Tesla_T4, nvidia.com/GP102GL_Tesla_P40). Extended resource names are case sensitive, so a VM copied from the examples requests a resource that no node has and stays Pending with "Insufficient nvidia.com/..." (see NVIDIA#89). The vGPU example also requested the passthrough resource of a P40 instead of the vGPU type that the example CR allows. Use the advertised names in the examples, and describe in the README how the names are derived and how to list them on a node. Signed-off-by: YoungjuKim <[email protected]>
rajatchopra
reviewed
Nov 2, 2026
rajatchopra
left a comment
rajatchopra
left a comment
There was a problem hiding this comment.
Correct.
Just concerned about bloated documentation. Could be squeezed I suspect.
Keep only what a user needs to get the name right: names are case sensitive, an example of each form, and where to look them up on a node. Signed-off-by: YoungjuKim <[email protected]>
Author
|
Thanks, agreed. In 169539a I cut the README addition from 9 lines to 2: names are case sensitive, one passthrough and one vGPU example, and where to check them on a node ( (Written with help from Claude (AI).) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example KubeVirt CR and VMIs use mixed-case resource names such as
nvidia.com/TU104GL_Tesla_T4andnvidia.com/GP102GL_Tesla_P40. Since 3b4d73f ("convert device names to capital letters", 2022) the plugin registers passthrough GPUs in upper case, for examplenvidia.com/TU104GL_TESLA_T4. Extended resource names are case sensitive, so a VM copied from the examples requests a resource that no node advertises and staysPendingwithInsufficient nvidia.com/.... This looks like what #89 ran into: the plugin log showsGK110BGL_TESLA_K40Mand the scheduler reportsInsufficient nvidia.com/GK110BGL_Tesla_K40m.The vGPU example also requested the passthrough resource of a P40 instead of the vGPU type that the example CR allows (
nvidia.com/GRID_T4-1Q).Changes:
examples/kubevirt-featuregate-cm.yaml,examples/vmi-gpu.yaml: use the upper-case names.examples/vmi-vgpu.yaml: requestnvidia.com/GRID_T4-1Q, which matches themediatedDevicesentry of the example CR.README.md: describe how the plugin derives resource names, and how to list them on a node.How I checked the names: I called
getDeviceName()frompkg/device_pluginon thepci.idsshipped with Ubuntu 26.04, andreadVgpuIDFromFileFunc()on anamefile containingGRID T4-1Q, with a throwaway test that is not part of this PR:go test ./pkg/...passes. This PR only changes docs and examples. I have not deployed the plugin itself on a cluster for this PR.Related: #89.
Prepared with help from Claude (AI), including the local checks described above.
🤖 Generated with Claude Code