Add ownerReference to NodeFeature CRs for garbage collection#1597
Merged
rajathagasthya merged 1 commit intomainfrom Jan 26, 2026
Merged
Add ownerReference to NodeFeature CRs for garbage collection#1597rajathagasthya merged 1 commit intomainfrom
rajathagasthya merged 1 commit intomainfrom
Conversation
rajathagasthya
requested review from
ArangoGutierrez,
cdesiniotis,
elezar and
tariq1890
rajathagasthya
force-pushed
the
feature/nodefeature-ownerref
branch
from
53edb01 to
997a9e9
Compare
Adds the Pod and Daemonset (controller reference) as owners, so that the NodeFeature CR is deleted when the GFD daemonset is deleted. This mirrors the behavior of how NFD adds ownerReferences to NodeFeature CRs it creates. Signed-off-by: Rajath Agasthya <[email protected]>
rajathagasthya
force-pushed
the
feature/nodefeature-ownerref
branch
from
997a9e9 to
3968b3d
Compare
cdesiniotis
approved these changes
Jan 23, 2026
cdesiniotis
reviewed
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Pod and Daemonset (controller reference) as owners, so that the NodeFeature CR is deleted when the GFD daemonset is deleted. This mirrors the behavior of how NFD adds ownerReferences to NodeFeature CRs it creates.