[release-0.18] Fix race condition in config-manager when label is unset#1577
Merged
elezar merged 1 commit intorelease-0.18from Jan 15, 2026
Merged
[release-0.18] Fix race condition in config-manager when label is unset#1577elezar merged 1 commit intorelease-0.18from
elezar merged 1 commit intorelease-0.18from
Conversation
When the node label (nvidia.com/device-plugin.config) is not set, a race condition could cause the config-manager to hang indefinitely on startup. The issue occurred when the informer's AddFunc fired before the first Get() call, setting current="" and broadcasting. When Get() was subsequently called, it found lastRead == current (both empty strings) and waited forever, as no future events would wake it up. This fix adds an 'initialized' flag to SyncableConfig to ensure the first Get() call never waits, regardless of timing. Subsequent Get() calls still wait properly when the value hasn't changed. Signed-off-by: Uri Sternik <[email protected]> (cherry picked from commit ab05ace)
Contributor
|
/ok to test 09d5135 |
cdesiniotis
approved these changes
Jan 7, 2026
elezar
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated backport of #1541 to
release-0.18✅ Cherry-pick completed successfully with no conflicts.
Original PR: #1541
Original Author: @uristernik
Cherry-picked commits (1):
ab05aceFix race condition in config-manager when label is unsetThis backport was automatically created by the backport bot.