Enable NodeFeature API by default in GFD#1504
Merged
Conversation
rajathagasthya
requested review from
ArangoGutierrez,
cdesiniotis,
elezar and
tariq1890
elezar
reviewed
Nov 18, 2025
This change enables NodeFeature API in GFD. This results in GFD creating in a new NodeFeature CR on startup. This commit also removes the redundant `enableNodeFeatureApi` helm value NodeFeature is now enabled by default in NFD since it's v0.17.0 release. The k8s-device-plugin helm chart has been using NFD v0.17.3 subchart since k8s-device-plugin's v0.18.0 release, so NodeFeature API has been enabled by default since then and this helm value has had no effect. Signed-off-by: Rajath Agasthya <[email protected]>
rajathagasthya
force-pushed
the
gfd-use-node-feature-api
branch
from
770eefe to
1cd8284
Compare
rajathagasthya
commented
Nov 25, 2025
tariq1890
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables NodeFeature API in GFD. This results in GFD creating
in a new NodeFeature CR on startup.
This commit also removes the redundant
enableNodeFeatureApihelm valueNodeFeature is now enabled by default in NFD since it's v0.17.0 release.
The k8s-device-plugin helm chart has been using NFD v0.17.3 subchart
since k8s-device-plugin's v0.18.0 release, so NodeFeature API has been
enabled by default since then and this helm value has had no effect.
Verification steps:
NodeFeatureCR is created./etc/kubernetes/node-feature-discovery/features.d/.