This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@elezar can someone have a look here?

Per Helm Standard Labels I think we should keep common app.kubernetes.io/name and app.kubernetes.io/instance for all pod controllers, and instead introduce app.kubernetes.io/component to each DaemonSet. Also templates won't need repetition and can then call a common one for name and component.

Thanks @peterzandbergen. Can you make sure commits are signed and fix the merge conflicts.

Per Helm Standard Labels I think we should keep common app.kubernetes.io/name and app.kubernetes.io/instance for all pod controllers, and instead introduce app.kubernetes.io/component to each DaemonSet. Also templates won't need repetition and can then call a common one for name and component.

Yeah, agree with this. We can just introduce additional app.kubernetes.io/component: {{ .component }} for each daemonset.

So each daemonsets / pods labels will be like:

# device-plugin
app.kubernetes.io/name: nvidia-device-plugin
app.kubernetes.io/instance: my-release
app.kubernetes.io/component: device-plugin

# gfd
app.kubernetes.io/name: nvidia-device-plugin
app.kubernetes.io/instance: my-release
app.kubernetes.io/component: gpu-feature-discovery

# mps
app.kubernetes.io/name: nvidia-device-plugin
app.kubernetes.io/instance: my-release
app.kubernetes.io/component: mps-control-daemon

Closing this PR in favor of #1716