Skip to content

Commit 6ed3c9f

Browse files
tariq1890tariq1890
committed
use the helm quote function to wrap boolean values in quotes
Signed-off-by: Tariq Ibrahim <[email protected]>
1 parent e120009 commit 6ed3c9f

3 files changed

Lines changed: 30 additions & 30 deletions

File tree

‎deployments/helm/nvidia-device-plugin/templates/daemonset-device-plugin.yml‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ spec:
7878
- name: CONFIG_FILE_DST
7979
value: "/config/config.yaml"
8080
- name: DEFAULT_CONFIG
81-
value: "{{ .Values.config.default }}"
81+
value: {{ .Values.config.default }}
8282
- name: FALLBACK_STRATEGIES
83-
value: "{{ join "," .Values.config.fallbackStrategies }}"
83+
value: {{ join "," .Values.config.fallbackStrategies }}
8484
- name: SEND_SIGNAL
8585
value: "false"
8686
- name: SIGNAL
@@ -114,9 +114,9 @@ spec:
114114
- name: CONFIG_FILE_DST
115115
value: "/config/config.yaml"
116116
- name: DEFAULT_CONFIG
117-
value: "{{ .Values.config.default }}"
117+
value: {{ .Values.config.default }}
118118
- name: FALLBACK_STRATEGIES
119-
value: "{{ join "," .Values.config.fallbackStrategies }}"
119+
value: {{ join "," .Values.config.fallbackStrategies }}
120120
- name: SEND_SIGNAL
121121
value: "true"
122122
- name: SIGNAL
@@ -137,38 +137,38 @@ spec:
137137
command: ["nvidia-device-plugin"]
138138
env:
139139
- name: MPS_ROOT
140-
value: "{{ .Values.mps.root }}"
140+
value: {{ .Values.mps.root }}
141141
{{- if typeIs "string" .Values.migStrategy }}
142142
- name: MIG_STRATEGY
143-
value: "{{ .Values.migStrategy }}"
143+
value: {{ .Values.migStrategy }}
144144
{{- end }}
145145
{{- if typeIs "bool" .Values.failOnInitError }}
146146
- name: FAIL_ON_INIT_ERROR
147-
value: "{{ .Values.failOnInitError }}"
147+
value: {{ .Values.failOnInitError }}
148148
{{- end }}
149149
{{- if typeIs "bool" .Values.compatWithCPUManager }}
150150
- name: PASS_DEVICE_SPECS
151-
value: "{{ .Values.compatWithCPUManager }}"
151+
value: {{ .Values.compatWithCPUManager | quote }}
152152
{{- end }}
153153
{{- if typeIs "string" .Values.deviceListStrategy }}
154154
- name: DEVICE_LIST_STRATEGY
155-
value: "{{ .Values.deviceListStrategy }}"
155+
value: {{ .Values.deviceListStrategy }}
156156
{{- end }}
157157
{{- if typeIs "string" .Values.deviceIDStrategy }}
158158
- name: DEVICE_ID_STRATEGY
159-
value: "{{ .Values.deviceIDStrategy }}"
159+
value: {{ .Values.deviceIDStrategy }}
160160
{{- end }}
161161
{{- if typeIs "string" .Values.nvidiaDriverRoot }}
162162
- name: NVIDIA_DRIVER_ROOT
163-
value: "{{ .Values.nvidiaDriverRoot }}"
163+
value: {{ .Values.nvidiaDriverRoot }}
164164
{{- end }}
165165
{{- if typeIs "bool" .Values.gdsEnabled }}
166166
- name: GDS_ENABLED
167-
value: "{{ .Values.gdsEnabled }}"
167+
value: {{ .Values.gdsEnabled | quote }}
168168
{{- end }}
169169
{{- if typeIs "bool" .Values.mofedEnabled }}
170170
- name: MOFED_ENABLED
171-
value: "{{ .Values.mofedEnabled }}"
171+
value: {{ .Values.mofedEnabled | quote }}
172172
{{- end }}
173173
{{- if eq $hasConfigMap "true" }}
174174
- name: CONFIG_FILE
@@ -234,7 +234,7 @@ spec:
234234
{{- if eq $hasConfigMap "true" }}
235235
- name: available-configs
236236
configMap:
237-
name: "{{ $configMapName }}"
237+
name: {{ $configMapName }}
238238
- name: config
239239
emptyDir: {}
240240
{{- end }}

‎deployments/helm/nvidia-device-plugin/templates/daemonset-gfd.yml‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ spec:
7878
- name: CONFIG_FILE_DST
7979
value: "/config/config.yaml"
8080
- name: DEFAULT_CONFIG
81-
value: "{{ .Values.config.default }}"
81+
value: {{ .Values.config.default }}
8282
- name: FALLBACK_STRATEGIES
83-
value: "{{ join "," .Values.config.fallbackStrategies }}"
83+
value: {{ join "," .Values.config.fallbackStrategies }}
8484
- name: SEND_SIGNAL
8585
value: "false"
8686
- name: SIGNAL
@@ -114,9 +114,9 @@ spec:
114114
- name: CONFIG_FILE_DST
115115
value: "/config/config.yaml"
116116
- name: DEFAULT_CONFIG
117-
value: "{{ .Values.config.default }}"
117+
value: {{ .Values.config.default }}
118118
- name: FALLBACK_STRATEGIES
119-
value: "{{ join "," .Values.config.fallbackStrategies }}"
119+
value: {{ join "," .Values.config.fallbackStrategies }}
120120
- name: SEND_SIGNAL
121121
value: "true"
122122
- name: SIGNAL
@@ -146,23 +146,23 @@ spec:
146146
fieldPath: metadata.namespace
147147
{{- if typeIs "string" .Values.migStrategy }}
148148
- name: MIG_STRATEGY
149-
value: "{{ .Values.migStrategy }}"
149+
value: {{ .Values.migStrategy }}
150150
{{- end }}
151151
{{- if typeIs "bool" .Values.failOnInitError }}
152152
- name: FAIL_ON_INIT_ERROR
153-
value: "{{ .Values.failOnInitError }}"
153+
value: {{ .Values.failOnInitError | quote }}
154154
{{- end }}
155155
{{- if typeIs "bool" .Values.noTimestamp }}
156156
- name: GFD_NO_TIMESTAMP
157-
value: "{{ .Values.noTimestamp}}"
157+
value: {{ .Values.noTimestamp | quote }}
158158
{{- end }}
159159
{{- if or (typeIs "string" .Values.sleepInterval) (typeIs "int" .Values.sleepInterval) }}
160160
- name: GFD_SLEEP_INTERVAL
161-
value: "{{ .Values.sleepInterval }}"
161+
value: {{ .Values.sleepInterval | quote }}
162162
{{- end }}
163163
{{- if typeIs "bool" .Values.nfd.enableNodeFeatureApi }}
164164
- name: GFD_USE_NODE_FEATURE_API
165-
value: "{{ .Values.nfd.enableNodeFeatureApi }}"
165+
value: {{ .Values.nfd.enableNodeFeatureApi | quote }}
166166
{{- end }}
167167
{{- if eq $hasConfigMap "true" }}
168168
- name: CONFIG_FILE
@@ -199,7 +199,7 @@ spec:
199199
{{- if eq $hasConfigMap "true" }}
200200
- name: available-configs
201201
configMap:
202-
name: "{{ $configMapName }}"
202+
name: {{ $configMapName }}
203203
- name: config
204204
emptyDir: {}
205205
{{- end }}

‎deployments/helm/nvidia-device-plugin/templates/daemonset-mps-control-daemon.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ spec:
8989
- name: CONFIG_FILE_DST
9090
value: "/config/config.yaml"
9191
- name: DEFAULT_CONFIG
92-
value: "{{ .Values.config.default }}"
92+
value: {{ .Values.config.default }}
9393
- name: FALLBACK_STRATEGIES
94-
value: "{{ join "," .Values.config.fallbackStrategies }}"
94+
value: {{ join "," .Values.config.fallbackStrategies }}
9595
- name: SEND_SIGNAL
9696
value: "false"
9797
- name: SIGNAL
@@ -126,9 +126,9 @@ spec:
126126
- name: CONFIG_FILE_DST
127127
value: "/config/config.yaml"
128128
- name: DEFAULT_CONFIG
129-
value: "{{ .Values.config.default }}"
129+
value: {{ .Values.config.default }}
130130
- name: FALLBACK_STRATEGIES
131-
value: "{{ join "," .Values.config.fallbackStrategies }}"
131+
value: {{ join "," .Values.config.fallbackStrategies }}
132132
- name: SEND_SIGNAL
133133
value: "true"
134134
- name: SIGNAL
@@ -153,7 +153,7 @@ spec:
153153
fieldPath: spec.nodeName
154154
{{- if typeIs "string" .Values.migStrategy }}
155155
- name: MIG_STRATEGY
156-
value: "{{ .Values.migStrategy }}"
156+
value: {{ .Values.migStrategy }}
157157
{{- end }}
158158
{{- if eq $hasConfigMap "true" }}
159159
- name: CONFIG_FILE
@@ -195,7 +195,7 @@ spec:
195195
{{- if eq $hasConfigMap "true" }}
196196
- name: available-configs
197197
configMap:
198-
name: "{{ $configMapName }}"
198+
name: {{ $configMapName }}
199199
- name: config
200200
emptyDir: {}
201201
{{- end }}

0 commit comments

Comments
 (0)