Skip to content

[release-26.3] store os release name and use it than recalculating from tag which is errorprone - #2268

Merged
rahulait merged 1 commit into
release-26.3from
backport-2244-to-release-26.3
Apr 7, 2026
Merged

rahulait merged 1 commit into
release-26.3from
backport-2244-to-release-26.3

Conversation

@github-actions

@github-actions github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Automated backport of #2244 to release-26.3

⚠️ This PR has merge conflicts that need manual resolution.

Original PR: #2244
Original Author: @rahulait

Cherry-picked commits (1):

  • 6afb205 store os release name and use it than recalculating from tag which is errorprone

Next Steps:

  1. Review the conflicts in the "Files changed" tab
  2. Check out this branch locally: git fetch origin backport-2244-to-release-26.3 && git checkout backport-2244-to-release-26.3
  3. Resolve conflicts manually
  4. Push the resolution: git push --force-with-lease origin backport-2244-to-release-26.3

Instructions for resolving conflicts
git fetch origin backport-2244-to-release-26.3
git checkout backport-2244-to-release-26.3
# Resolve conflicts in your editor
git add .
git commit
git push --force-with-lease origin backport-2244-to-release-26.3

@copy-pr-bot

copy-pr-bot Bot commented Apr 6, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rahulait
rahulait marked this pull request as ready for review April 6, 2026 18:51
@rahulait

rahulait commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

/ok to test d277642

Comment thread controllers/object_controls.go Resolved
@rahulait
rahulait force-pushed the backport-2244-to-release-26.3 branch from d277642 to 9652102 Compare April 6, 2026 18:59
… errorprone

Signed-off-by: Rahul Sharma <[email protected]>
(cherry picked from commit 6afb205)
@rahulait
rahulait force-pushed the backport-2244-to-release-26.3 branch from 9652102 to 01ad7d1 Compare April 6, 2026 19:03
@rahulait

rahulait commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

/ok to test 01ad7d1

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 27.951% (+0.2%) from 27.79% — backport-2244-to-release-26.3 into release-26.3

@tariq1890

Copy link
Copy Markdown
Contributor

@rahulait Has this PR been rebased on top of #2267 ?

@rahulait

rahulait commented Apr 7, 2026 •

Copy link
Copy Markdown
Contributor

@rahulait Has this PR been rebased on top of #2267 ?

Yeah, it is. Current backport branch is 1 commit ahead of release-26.3 branch

git rev-list --left-right --count release-26.3..backport-2244-to-release-26.3
0	1

Initially it contained changes of #2267 in this PR as well (see commit 9652102). I had to get the #2267 merged first into release-26.3 so that I can have this PR independent of the changes of other PR.

@rahulait
rahulait merged commit f4269d0 into release-26.3 Apr 7, 2026
17 checks passed
@tariq1890
tariq1890 deleted the backport-2244-to-release-26.3 branch April 7, 2026 18:08
nicolerenee added a commit to frecklelabs/k8s that referenced this pull request Jul 1, 2026
The Talos version-parsing fix (NVIDIA/gpu-operator#2244, backported via
NVIDIA/gpu-operator#2268) is contained in the v26.3.3 release, so the
temporary ghcr.io/nvidia/gpu-operator:670be908 override is no longer
needed.

Co-Authored-By: Claude Fable 5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants