Skip to content

mount /lib/modules from host when using precompiled driver - #2252

Merged
tariq1890 merged 1 commit into
NVIDIA:mainfrom
fcrozat:precompiled_lib_modules_main
Apr 3, 2026
Merged

tariq1890 merged 1 commit into
NVIDIA:mainfrom
fcrozat:precompiled_lib_modules_main

Conversation

@fcrozat

@fcrozat fcrozat commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

This will ensure precompiled driver container has access to host kernel modules.

Description

This is needed for precompiled driver container for SLES 15 SP7 and SLES 16, provided by SUSE at https://registry.suse.com/repositories/third-party-nvidia-driver-sles15 resp. https://registry.suse.com/repositories/third-party-nvidia-driver-sles16 which can use underlying host kernel modules without the need to have the entire kernel part of the driver container.

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Unit test added and tested on a k3s cluster running SLES 15 SP7 and SLES 16.0

This PR replaces #2040 to be non distribution specific.

@copy-pr-bot

copy-pr-bot Bot commented Mar 26, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Comment thread controllers/object_controls.go Resolved
@fcrozat
fcrozat force-pushed the precompiled_lib_modules_main branch from ff07c5e to a0b68c1 Compare April 3, 2026 20:45
@tariq1890

Copy link
Copy Markdown
Contributor

/ok to test a0b68c1

@tariq1890

Copy link
Copy Markdown
Contributor

@fcrozat Looks like the unit tests need fixing. Can you also squash your commit history?

@fcrozat
fcrozat force-pushed the precompiled_lib_modules_main branch from a0b68c1 to a7323f5 Compare April 3, 2026 21:36
@fcrozat

fcrozat commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

@fcrozat Looks like the unit tests need fixing. Can you also squash your commit history?

unit test fixed, history squashed.

@tariq1890

Copy link
Copy Markdown
Contributor

/ok to test a7323f5

@cdesiniotis

Copy link
Copy Markdown
Contributor

@tariq1890 are we planning to cherry-pick this to release-26.3?

@tariq1890

Copy link
Copy Markdown
Contributor

@tariq1890 are we planning to cherry-pick this to release-26.3?

Yes

@tariq1890 tariq1890 added this to the v26.3.1 milestone Apr 3, 2026
@tariq1890
tariq1890 merged commit 7ad7a1d into NVIDIA:main Apr 3, 2026
19 checks passed
@tariq1890

Copy link
Copy Markdown
Contributor

/cherry-pick release-26.3

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

🤖 Backport PR created for release-26.3: #2267 ✅

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

🤖 Updated existing backport PR for release-26.3: #2267 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants