Repository navigation
store os release name and use it than recalculating from tag which is errorprone - #2244
Merged
Merged
Conversation
rahulait
requested review from
cdesiniotis,
karthikvetrivel,
rajathagasthya,
shivamerla and
tariq1890
as code owners
March 24, 2026 03:33
rahulait
force-pushed
the
fix-issue-2239
branch
from
March 24, 2026 04:06
e2e31ca to
670be90
Compare
rahulait
changed the title
tariq1890
reviewed
Apr 2, 2026
Contributor
Author
|
/ok to test 092582b |
tariq1890
reviewed
Apr 3, 2026
Contributor
|
Looks like the unit tests are failing |
tariq1890
reviewed
Apr 6, 2026
… errorprone Signed-off-by: Rahul Sharma <[email protected]>
Contributor
Author
Should be fixed now. |
tariq1890
approved these changes
Apr 6, 2026
Contributor
Author
|
/cherry-pick release-26.3 |
Contributor
|
🤖 Backport PR created for |
nicolerenee
added a commit
to frecklelabs/k8s
that referenced
this pull request
Jul 1, 2026
The Talos version-parsing fix (NVIDIA/gpu-operator#2244, backported via NVIDIA/gpu-operator#2268) is contained in the v26.3.3 release, so the temporary ghcr.io/nvidia/gpu-operator:670be908 override is no longer needed. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2239
Instead of re-calculating os release from the tag (which is errorprone as there can be different combinations and all might not be covered by code), store the os-release when its fetched from node label and then re-use it where required.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing