Merge pull request #54 from elezar/fix-is-fabric-attached

elezar · web-flow · commit e9b89036f0d2 · 2025-02-12T19:23:13.000+01:00
Treat zero cluster UUID as non-fabric-attached
diff --git a/pkg/nvlib/device/device.go b/pkg/nvlib/device/device.go
@@ -222,6 +222,9 @@ func (d *device) IsFabricAttached() (bool, error) {
 		if info.State != nvml.GPU_FABRIC_STATE_COMPLETED {
 			return false, nil
 		}
+		if info.ClusterUuid == [16]uint8{} {
+			return false, nil
+		}
 		if nvml.Return(info.Status) != nvml.SUCCESS {
 			return false, nil
 		}
@@ -240,6 +243,9 @@ func (d *device) IsFabricAttached() (bool, error) {
 		if info.State != nvml.GPU_FABRIC_STATE_COMPLETED {
 			return false, nil
 		}
+		if info.ClusterUuid == [16]uint8{} {
+			return false, nil
+		}
 		if nvml.Return(info.Status) != nvml.SUCCESS {
 			return false, nil
 		}

Original file line number	Diff line number	Diff line change
`@@ -222,6 +222,9 @@ func (d *device) IsFabricAttached() (bool, error) {`
`222`	`222`	`if info.State != nvml.GPU_FABRIC_STATE_COMPLETED {`
`223`	`223`	`return false, nil`
`224`	`224`	`}`
	`225`	`+ if info.ClusterUuid == [16]uint8{} {`
	`226`	`+ return false, nil`
	`227`	`+ }`
`225`	`228`	`if nvml.Return(info.Status) != nvml.SUCCESS {`
`226`	`229`	`return false, nil`
`227`	`230`	`}`
`@@ -240,6 +243,9 @@ func (d *device) IsFabricAttached() (bool, error) {`
`240`	`243`	`if info.State != nvml.GPU_FABRIC_STATE_COMPLETED {`
`241`	`244`	`return false, nil`
`242`	`245`	`}`
	`246`	`+ if info.ClusterUuid == [16]uint8{} {`
	`247`	`+ return false, nil`
	`248`	`+ }`
`243`	`249`	`if nvml.Return(info.Status) != nvml.SUCCESS {`
`244`	`250`	`return false, nil`
`245`	`251`	`}`