Force CMake>=3.5 when building cuDNN FE#10
Merged
szalpal merged 1 commit intoNVIDIA:mainfrom Apr 2, 2025
Merged
Conversation
cuDNN FE depends on dlpack 0.8, which uses CMake 3.2. CMake 4.0 dropped support for CMake<3.5. This shouldn't break anything in DLPack as a similar fix was done recently upstream (dmlc/dlpack#163). Signed-off-by: Rostan Tabet <[email protected]>
szalpal
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cuDNN FrontEnd depends on DLPack 0.8, which uses CMake 3.2.
CMake 4.0 dropped support for CMake<3.5. This shouldn't break anything in DLPack as a similar fix was done recently upstream1. This fix might not be necessary in the future if cuDNN FE switches to a version of DLPack supporting newer CMake.
Footnotes
https://github.com/dmlc/dlpack/pull/163 ↩