fix(nvqpp): insert quake.discriminate for `for (bool b : mz(reg))` by aryanputta · Pull Request #4688 · NVIDIA/cuda-quantum

aryanputta · 2026-06-06T12:24:20Z

Summary

A range-based for loop with a bool loop variable over a multi-qubit mz result crashes cudaq-quake in the verifier:

'cc.store' op failed to verify that type of value matches element type of pointer

Root cause

In QuakeBridgeVisitor::TraverseCXXForRangeStmt (lib/Frontend/nvqpp/ConvertStmt.cpp), mz(reg) lowers to !cc.stdvec<!cc.measure_handle>, so the container element type is !cc.measure_handle, not i1. The non-reference / non-const "create a local copy" path loads the element and stores it into the loop variable's slot:

Value atOffset = cc::LoadOp::create(builder, loc, addr);   // !cc.measure_handle
if (isBool)                                                // false: eleTy is measure_handle, not i1
  atOffset = cc::CastOp::create(..., builder.getI1Type(), atOffset);
cc::StoreOp::create(builder, loc, atOffset, iterVar);      // store measure_handle into !cc.ptr<i1>

For for (bool b : mz(reg)) the loop variable slot is !cc.ptr<i1>, so the store has mismatched value/pointer types and the verifier rejects the module. for (auto b : mz(reg)) works because the slot is !cc.ptr<!cc.measure_handle> and the discriminate is inserted later at the operator bool() use site.

Fix

When the loaded value is a !cc.measure_handle and the loop variable slot is i1, lower the handle through quake.discriminate before the store, mirroring the single sanctioned coercion in measure_handle::operator bool() (ConvertExpr.cpp). The auto (handle-typed) binding is unchanged.

Test

Adds test/AST-Quake/range_for_measure.cpp covering both the bool binding (discriminate inserted, stores i1) and the auto binding (handle retained). Pre-fix, cudaq-quake crashes on the bool case, so the CHECK-LABEL alone fails without the fix.

copy-pr-bot · 2026-06-06T12:24:23Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

schweitzpgi

LGTM. Thanks for the bug fix.

khalatepradnya · 2026-06-08T22:11:30Z

/ok to test 3ec0720

Command Bot: Processing...

khalatepradnya

Thank you, @aryanputta for the contribution! This fixes a bug, but the code changes can be polished IMO.

github-actions · 2026-06-08T22:50:29Z

CI Summary (`push`) — ✅ passed

Run #27238548072 · ✅ 6 · ⏩ 7 · ❌ 0 · ⛔ 0

Top-level jobs (13)

Job	Result
`binaries`	⏩ skipped
`build_and_test`	✅ success
`config_devdeps`	✅ success
`config_source_build`	⏩ skipped
`config_wheeldeps`	✅ success
`devdeps`	✅ success
`docker_image`	⏩ skipped
`gen_code_coverage`	⏩ skipped
`metadata`	✅ success
`python_metapackages`	⏩ skipped
`python_wheels`	⏩ skipped
`source_build`	⏩ skipped
`wheeldeps`	✅ success

⏩ Skipped jobs (7) — intentionally skipped on PR builds; run on merge_group / workflow_dispatch

Job
`binaries`
`config_source_build`
`docker_image`
`gen_code_coverage`
`python_metapackages`
`python_wheels`
`source_build`

All sub-jobs (42) — every matrix leg, with links

Job	Status	Link
Build and test (amd64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Python)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Python)	✅ success	view
CI Summary	❔ in_progress	view
Configure build (devdeps)	✅ success	view
Configure build (source_build)	⏩ skipped	view
Configure build (wheeldeps)	✅ success	view
Create CUDA Quantum installer	⏩ skipped	view
Create Docker images	⏩ skipped	view
Create Python metapackages	⏩ skipped	view
Create Python wheels	⏩ skipped	view
Gen code coverage	⏩ skipped	view
Load dependencies (amd64, gcc12) / Caching	✅ success	view
Load dependencies (amd64, gcc12) / Finalize	✅ success	view
Load dependencies (amd64, gcc12) / Metadata	✅ success	view
Load dependencies (amd64, llvm) / Caching	✅ success	view
Load dependencies (amd64, llvm) / Finalize	✅ success	view
Load dependencies (amd64, llvm) / Metadata	✅ success	view
Load dependencies (arm64, gcc12) / Caching	✅ success	view
Load dependencies (arm64, gcc12) / Finalize	✅ success	view
Load dependencies (arm64, gcc12) / Metadata	✅ success	view
Load dependencies (arm64, llvm) / Caching	✅ success	view
Load dependencies (arm64, llvm) / Finalize	✅ success	view
Load dependencies (arm64, llvm) / Metadata	✅ success	view
Load source build cache	⏩ skipped	view
Load wheel dependencies (amd64, 12.6) / Caching	✅ success	view
Load wheel dependencies (amd64, 12.6) / Finalize	✅ success	view
Load wheel dependencies (amd64, 12.6) / Metadata	✅ success	view
Load wheel dependencies (amd64, 13.0) / Caching	✅ success	view
Load wheel dependencies (amd64, 13.0) / Finalize	✅ success	view
Load wheel dependencies (amd64, 13.0) / Metadata	✅ success	view
Load wheel dependencies (arm64, 12.6) / Caching	✅ success	view
Load wheel dependencies (arm64, 12.6) / Finalize	✅ success	view
Load wheel dependencies (arm64, 12.6) / Metadata	✅ success	view
Load wheel dependencies (arm64, 13.0) / Caching	✅ success	view
Load wheel dependencies (arm64, 13.0) / Finalize	✅ success	view
Load wheel dependencies (arm64, 13.0) / Metadata	✅ success	view
Prepare cache clean-up	❔ in_progress	view
Retrieve PR info	✅ success	view

✅ Required checks (6/6) — declared in .github/required-checks.yml for push

Required check	Status	Link
Build and test (amd64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Python)	✅ success	view

aryanputta · 2026-06-09T14:34:39Z

@khalatepradnya Added the bound-handle check and the negative test...thank you for the review!
One idea I wanted to float for future cleanup (happy to do it in a follow-up or here if you prefer):

The storeDominatesLoad + isBoundHandle pair could move from file-static in ConvertExpr.cpp into ASTBridge.h as inline free functions under namespace cudaq::detail. That would:

Drop the cross-TU forward declaration in ConvertStmt.cpp
Make the helpers naturally available to any future Convert*.cpp that needs them
Keep the header change contained since ASTBridge.h is only included by 5 files in lib/Frontend/nvqpp/

The required additions to ASTBridge.h would be #include "cudaq/Optimizer/Dialect/Quake/QuakeOps.h" and #include "llvm/ADT/SmallPtrSet.h". Does that refactor direction sound good to you, or would you prefer a different approach?

khalatepradnya · 2026-06-09T19:41:16Z

@aryanputta : Thanks, for the updates. I will review today.
Can you run the code formatter to fix the CI failure on Basic content checks? I find it easiest to run the pre-commit checks as pre-commit run --all-files --hook-stage pre-push

khalatepradnya · 2026-06-09T19:42:15Z

/ok to test 82e7844

Command Bot: Processing...

aryanputta · 2026-06-09T21:27:56Z

Hi @khalatepradnya, the PR is updated at 9afb8afa. Two issues from the last CI run are fixed:

All four commits have Signed-off-by. Ready for /ok to test 9afb8afa when you get a chance.

khalatepradnya · 2026-06-09T21:37:59Z

Hi @khalatepradnya, the PR is updated at 9afb8afa. Two issues from the last CI run are fixed:

All four commits have Signed-off-by. Ready for /ok to test 9afb8afa when you get a chance.

Thanks, @aryanputta for the updates.

I don't think removing the negative test is the right resolution on its own. The test was doing its job by exposing that the range-for guard is ineffective. atOffset is loaded through cc.stdvec_data, and isBoundHandle returns true whenever it can't peel the pointer back to a scalar cc.alloca. Since a range-for over measurement handles is always iterating a !cc.stdvec, that fall-through is hit on every reachable path, so the guard never fires and the reportClangError branch is dead code.

Two coherent ways forward:

Keep the guard → make it real. isBoundHandle would need to peel cc::StdvecDataOp and decide boundedness from the vector's provenance (produced by mz/mx/my, directly or via a local store, vs. default/sized-constructed). Then the negative test stays.
Defer to [C++] [bridge] measure_handle: definite-assignment analysis #4479 → remove the dead code. Revert to the plain quake.discriminate insertion and also drop the un-static on isBoundHandle and the cross-TU forward declaration, with a // TODO(#4479) note. As written, the isBoundHandle call in ConvertStmt.cpp is misleading: it reads as protecting the range-for vector case it was added for, but it never does.

For a fix scoped to #4562, I'd lean toward the second.

khalatepradnya · 2026-06-09T21:41:02Z

Additional note: If you "Update branch" / align with main, the CI is more likely to not have cache misses and tends to go faster.

Fixes NVIDIA#4562. A range-based `for` loop with a `bool` loop variable over a multi-qubit `mz` result lowers to a container of `!cc.measure_handle`. The bridge loaded each element and stored it directly into the `i1` loop-variable slot, so the `cc.store` value type (`!cc.measure_handle`) and pointer element type (`i1`) disagreed and the verifier crashed `cudaq-quake`. When the loaded element is a `!cc.measure_handle` and the loop-variable slot is `i1`, lower the handle through `quake.discriminate` before the store, mirroring the single sanctioned coercion in `measure_handle::operator bool()` (ConvertExpr.cpp). The `auto` (handle-typed) binding keeps the handle and is unchanged. Diagnosing discrimination of an unbound handle is intentionally out of scope here; definite-assignment analysis for measure_handle is tracked by NVIDIA#4479, referenced in a TODO at the insertion site. Adds test/AST-Quake/range_for_measure.cpp covering both the `bool` binding (discriminate inserted, stores i1) and the `auto` binding (handle retained). Signed-off-by: Aryan <[email protected]>

aryanputta · 2026-06-09T21:53:58Z

Thanks @khalatepradnya. Went with option 2, scoped to #4562.

What changed at 37fac382:

Removed the isBoundHandle guard and the reportClangError branch from the range-for path. As you noted, atOffset comes through cc.stdvec_data, so isBoundHandle always hit the non-alloca fall-through and returned true, making that branch dead code.
Reverted the un-static on isBoundHandle in ConvertExpr.cpp, so that file is back to its main state (zero net change).
Dropped the cross-TU forward declaration and the llvm/ADT/SmallPtrSet.h include in ConvertStmt.cpp.
Left a // TODO(NVIDIA/cuda-quantum#4479) at the insertion site noting that discriminating an unbound handle is not diagnosed here, deferred to the definite-assignment work.

The range-for body is now just the plain quake.discriminate insertion, gated on the loaded element being a !cc.measure_handle and the loop-variable slot being i1. The auto binding is untouched.

Also rebased the branch onto current main for the cache hits you mentioned, and squashed to a single commit. clang-format (v22) passes clean on ConvertStmt.cpp.

Ready for /ok to test 37fac382 when you get a chance.

khalatepradnya · 2026-06-09T21:58:28Z

/ok to test 37fac38

Command Bot: Processing...

khalatepradnya

LGTM. Thanks, @aryanputta for the fix!

github-actions · 2026-06-10T00:36:09Z

CI Summary (`merge_group`) — ✅ passed

Run #27243422271 · ✅ 12 · ⏩ 1 · ❌ 0 · ⛔ 0

Top-level jobs (13)

Job	Result
`binaries`	✅ success
`build_and_test`	✅ success
`config_devdeps`	✅ success
`config_source_build`	✅ success
`config_wheeldeps`	✅ success
`devdeps`	✅ success
`docker_image`	✅ success
`gen_code_coverage`	⏩ skipped
`metadata`	✅ success
`python_metapackages`	✅ success
`python_wheels`	✅ success
`source_build`	✅ success
`wheeldeps`	✅ success

⏩ Skipped jobs (1) — intentionally skipped on PR builds; run on merge_group / workflow_dispatch

Job
`gen_code_coverage`

All sub-jobs (178) — every matrix leg, with links

Job	Status	Link
Build and test (amd64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Python)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, gcc12, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Python)	✅ success	view
CI Summary	❔ in_progress	view
Configure build (devdeps)	✅ success	view
Configure build (source_build)	✅ success	view
Configure build (wheeldeps)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Prepare cache clean-up	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Prepare validation	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Staging	⏩ skipped	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (debian:12)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (fedora:42)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (opensuse/leap:15.5)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (redhat/ubi9:9.6)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (ubuntu:22.04)	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Prepare cache clean-up	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Prepare validation	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Staging	⏩ skipped	view
Create CUDA Quantum installer (amd64, 13.0) / Validate installer (debian:12)	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Validate installer (fedora:42)	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Validate installer (opensuse/leap:15.5)	✅ success	view
Create CUDA Quantum installer (amd64, 13.0) / Validate installer (ubuntu:22.04)	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Prepare cache clean-up	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Prepare validation	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Staging	⏩ skipped	view
Create CUDA Quantum installer (arm64, 12.6) / Validate installer (redhat/ubi9:9.6)	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Validate installer (ubuntu:22.04)	✅ success	view
Create CUDA Quantum installer (arm64, 13.0) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (arm64, 13.0) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (arm64, 13.0) / Prepare cache clean-up	✅ success	view
Create CUDA Quantum installer (arm64, 13.0) / Prepare validation	✅ success	view
Create CUDA Quantum installer (arm64, 13.0) / Staging	⏩ skipped	view
Create CUDA Quantum installer (arm64, 13.0) / Validate installer (ubuntu:22.04)	✅ success	view
Create Docker images (amd64) / Documentation	✅ success	view
Create Docker images (amd64) / Metadata	✅ success	view
Create Docker images (amd64) / Prepare cache clean-up	✅ success	view
Create Docker images (amd64) / Staging	⏩ skipped	view
Create Docker images (amd64) / Validation	✅ success	view
Create Docker images (amd64) / cuda-quantum (release)	✅ success	view
Create Docker images (amd64) / cuda-quantum-dev (debug)	✅ success	view
Create Docker images (amd64) / open-mpi	⏩ skipped	view
Create Docker images (arm64) / Documentation	⏩ skipped	view
Create Docker images (arm64) / Metadata	✅ success	view
Create Docker images (arm64) / Prepare cache clean-up	✅ success	view
Create Docker images (arm64) / Staging	⏩ skipped	view
Create Docker images (arm64) / Validation	✅ success	view
Create Docker images (arm64) / cuda-quantum (release)	✅ success	view
Create Docker images (arm64) / cuda-quantum-dev (debug)	✅ success	view
Create Docker images (arm64) / open-mpi	⏩ skipped	view
Create Python metapackages / Build Python metapackages	✅ success	view
Create Python metapackages / Test Python metapackages (12.6, 3.11)	✅ success	view
Create Python metapackages / Test Python metapackages (12.6, 3.13)	✅ success	view
Create Python metapackages / Test Python metapackages (13.0, 3.11)	✅ success	view
Create Python metapackages / Test Python metapackages (13.0, 3.13)	✅ success	view
Create Python metapackages / Test Python metapackages (3.11)	✅ success	view
Create Python metapackages / Test Python metapackages (3.13)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Build Python 3.11 wheel	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Prepare validation	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Staging	⏩ skipped	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi9:9.6)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi9:9.6, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (ubuntu:22.04)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (ubuntu:22.04, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Build Python 3.11 wheel	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Prepare validation	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Staging	⏩ skipped	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (redhat/ubi8:8.10)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (redhat/ubi9:9.6)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (redhat/ubi9:9.6, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (ubuntu:22.04)	✅ success	view
Create Python wheels (amd64, 3.11, 13.0) / Validate wheel (ubuntu:22.04, --user)	✅ success	view
Create Python wheels (amd64, 3.13, 12.6) / Build Python 3.13 wheel	✅ success	view
Create Python wheels (amd64, 3.13, 12.6) / Prepare validation	✅ success	view
Create Python wheels (amd64, 3.13, 12.6) / Staging	⏩ skipped	view
Create Python wheels (amd64, 3.13, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (amd64, 3.13, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (amd64, 3.13, 13.0) / Build Python 3.13 wheel	✅ success	view
Create Python wheels (amd64, 3.13, 13.0) / Prepare validation	✅ success	view
Create Python wheels (amd64, 3.13, 13.0) / Staging	⏩ skipped	view
Create Python wheels (amd64, 3.13, 13.0) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (amd64, 3.13, 13.0) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Build Python 3.11 wheel	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Prepare validation	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Staging	⏩ skipped	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi9:9.6)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi9:9.6, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (ubuntu:22.04)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (ubuntu:22.04, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Build Python 3.11 wheel	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Prepare validation	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Staging	⏩ skipped	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (redhat/ubi8:8.10)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (redhat/ubi9:9.6)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (redhat/ubi9:9.6, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (ubuntu:22.04)	✅ success	view
Create Python wheels (arm64, 3.11, 13.0) / Validate wheel (ubuntu:22.04, --user)	✅ success	view
Create Python wheels (arm64, 3.13, 12.6) / Build Python 3.13 wheel	✅ success	view
Create Python wheels (arm64, 3.13, 12.6) / Prepare validation	✅ success	view
Create Python wheels (arm64, 3.13, 12.6) / Staging	⏩ skipped	view
Create Python wheels (arm64, 3.13, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (arm64, 3.13, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (arm64, 3.13, 13.0) / Build Python 3.13 wheel	✅ success	view
Create Python wheels (arm64, 3.13, 13.0) / Prepare validation	✅ success	view
Create Python wheels (arm64, 3.13, 13.0) / Staging	⏩ skipped	view
Create Python wheels (arm64, 3.13, 13.0) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (arm64, 3.13, 13.0) / Validate wheel (fedora:42, --user)	✅ success	view
Gen code coverage	⏩ skipped	view
Load dependencies (amd64, gcc12) / Caching	✅ success	view
Load dependencies (amd64, gcc12) / Finalize	✅ success	view
Load dependencies (amd64, gcc12) / Metadata	✅ success	view
Load dependencies (amd64, llvm) / Caching	✅ success	view
Load dependencies (amd64, llvm) / Finalize	✅ success	view
Load dependencies (amd64, llvm) / Metadata	✅ success	view
Load dependencies (arm64, gcc12) / Caching	✅ success	view
Load dependencies (arm64, gcc12) / Finalize	✅ success	view
Load dependencies (arm64, gcc12) / Metadata	✅ success	view
Load dependencies (arm64, llvm) / Caching	✅ success	view
Load dependencies (arm64, llvm) / Finalize	✅ success	view
Load dependencies (arm64, llvm) / Metadata	✅ success	view
Load source build cache (amd64, 12.6) / Caching	✅ success	view
Load source build cache (amd64, 12.6) / Finalize	✅ success	view
Load source build cache (amd64, 12.6) / Metadata	✅ success	view
Load source build cache (amd64, 13.0) / Caching	✅ success	view
Load source build cache (amd64, 13.0) / Finalize	✅ success	view
Load source build cache (amd64, 13.0) / Metadata	✅ success	view
Load source build cache (arm64, 12.6) / Caching	✅ success	view
Load source build cache (arm64, 12.6) / Finalize	✅ success	view
Load source build cache (arm64, 12.6) / Metadata	✅ success	view
Load source build cache (arm64, 13.0) / Caching	✅ success	view
Load source build cache (arm64, 13.0) / Finalize	✅ success	view
Load source build cache (arm64, 13.0) / Metadata	✅ success	view
Load wheel dependencies (amd64, 12.6) / Caching	✅ success	view
Load wheel dependencies (amd64, 12.6) / Finalize	✅ success	view
Load wheel dependencies (amd64, 12.6) / Metadata	✅ success	view
Load wheel dependencies (amd64, 13.0) / Caching	✅ success	view
Load wheel dependencies (amd64, 13.0) / Finalize	✅ success	view
Load wheel dependencies (amd64, 13.0) / Metadata	✅ success	view
Load wheel dependencies (arm64, 12.6) / Caching	✅ success	view
Load wheel dependencies (arm64, 12.6) / Finalize	✅ success	view
Load wheel dependencies (arm64, 12.6) / Metadata	✅ success	view
Load wheel dependencies (arm64, 13.0) / Caching	✅ success	view
Load wheel dependencies (arm64, 13.0) / Finalize	✅ success	view
Load wheel dependencies (arm64, 13.0) / Metadata	✅ success	view
Prepare cache clean-up	✅ success	view
Retrieve PR info	✅ success	view

✅ Required checks (39/39) — declared in .github/required-checks.yml for merge_group

Required check	Status	Link
Build and test (amd64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, gcc12, openmpi) / Dev environment (Python)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (debian:12)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (fedora:42)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (opensuse/leap:15.5)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (redhat/ubi9:9.6)	✅ success	view
Create CUDA Quantum installer (amd64, 12.6) / Validate installer (ubuntu:22.04)	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Build CUDA Quantum assets	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Minimal OpenMPI installation	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Validate installer (redhat/ubi9:9.6)	✅ success	view
Create CUDA Quantum installer (arm64, 12.6) / Validate installer (ubuntu:22.04)	✅ success	view
Create Docker images (amd64) / Documentation	✅ success	view
Create Docker images (amd64) / Validation	✅ success	view
Create Docker images (arm64) / Validation	✅ success	view
Create Python metapackages / Build Python metapackages	✅ success	view
Create Python metapackages / Test Python metapackages (3.11)	✅ success	view
Create Python metapackages / Test Python metapackages (3.13)	✅ success	view
Create Python metapackages / Test Python metapackages (12.6, 3.11)	✅ success	view
Create Python metapackages / Test Python metapackages (12.6, 3.13)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (amd64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (debian:12, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (debian:12)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (fedora:42, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (fedora:42)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10, --user)	✅ success	view
Create Python wheels (arm64, 3.11, 12.6) / Validate wheel (redhat/ubi8:8.10)	✅ success	view

…andle` vector (NVIDIA#4724) ### Summary * Follow-up to PR NVIDIA#4688 * Diagnose `for (bool b : v)` over a `std::vector<measure_handle>` whose handles were never measured. The loop discriminates each element, so an unbound vector lowers `quake.discriminate` onto a `cc.undef` and reads a result that never existed. --------- Signed-off-by: Pradnya Khalate <[email protected]> Co-authored-by: Cursor <[email protected]>

schweitzpgi requested a review from khalatepradnya June 8, 2026 16:51

schweitzpgi reviewed Jun 8, 2026

View reviewed changes

khalatepradnya reviewed Jun 8, 2026

View reviewed changes

Comment thread cudaq/lib/Frontend/nvqpp/ConvertStmt.cpp Resolved

khalatepradnya reviewed Jun 8, 2026

View reviewed changes

aryanputta force-pushed the fix/quake-range-for-measure-bool branch from 62d1271 to dd95def Compare June 9, 2026 21:12

aryanputta force-pushed the fix/quake-range-for-measure-bool branch from 9afb8af to 37fac38 Compare June 9, 2026 21:53

khalatepradnya approved these changes Jun 9, 2026

View reviewed changes

khalatepradnya enabled auto-merge June 9, 2026 22:04

khalatepradnya added this pull request to the merge queue Jun 9, 2026

Merged via the queue into NVIDIA:main with commit e94591d Jun 10, 2026
91 checks passed

github-actions Bot pushed a commit that referenced this pull request Jun 10, 2026

Cleaning up docs preview for PR #4688.

75148f2

khalatepradnya mentioned this pull request Jun 11, 2026

Follow-up to PR #4688: diagnose iterating an unbound measure_handle vector #4724

Merged

Conversation

aryanputta commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

Fix

Test

Uh oh!

copy-pr-bot Bot commented Jun 6, 2026

Uh oh!

schweitzpgi left a comment

Choose a reason for hiding this comment

Uh oh!

khalatepradnya commented Jun 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

khalatepradnya left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Summary (push) — ✅ passed

Uh oh!

aryanputta commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khalatepradnya commented Jun 9, 2026

Uh oh!

khalatepradnya commented Jun 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aryanputta commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khalatepradnya commented Jun 9, 2026

Uh oh!

khalatepradnya commented Jun 9, 2026

Uh oh!

aryanputta commented Jun 9, 2026

Uh oh!

khalatepradnya commented Jun 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khalatepradnya left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Summary (merge_group) — ✅ passed

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aryanputta commented Jun 6, 2026 •

edited

Loading

khalatepradnya commented Jun 8, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jun 8, 2026 •

edited

Loading

CI Summary (`push`) — ✅ passed

aryanputta commented Jun 9, 2026 •

edited

Loading

khalatepradnya commented Jun 9, 2026 •

edited by github-actions Bot

Loading

aryanputta commented Jun 9, 2026 •

edited

Loading

khalatepradnya commented Jun 9, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jun 10, 2026 •

edited

Loading

CI Summary (`merge_group`) — ✅ passed