You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix CI job-name evaluation when configuration is skipped - #3464
CI intentionally skips its NVIDIA-only jobs in forks. However, GitHub can still evaluate the four build-job display names, which parse detect-changes.outputs.bindings-config using fromJSON. When detect-changes is skipped, that output is empty, and parsing it can turn an intentionally skipped workflow into a failed run.
Add an empty-object fallback in those four display-name expressions so the workflow can conclude skipped as intended. The fallback affects display names only; build configuration, matrices, execution conditions, and normal job names remain unchanged.
xref: ctk-next PR 850
Validation
SKIP=lychee pre-commit run --all-files passed, including actionlint.
The same workflow change was validated with a manual dispatch with the repository-owner guard false; the workflow correctly concluded skipped.
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Chores
Improved build labeling reliability across Linux and Windows platforms, including ARM64 variants. Build labels now handle missing configuration output more consistently, while preserving the existing CUDA-major selection for Windows ARM64. These changes affect build reporting and do not change application features or behavior.
The CI workflow adds an empty JSON object fallback when four platform build job names parse empty or unset bindings-config output. The Windows ARM64 job retains its existing single-CUDA-major label selection.
Changes: CI build job labels
Layer / File(s)
Summary
Build job name fallback .github/workflows/ci.yml
Linux, Linux ARM64, Windows, and Windows ARM64 build names use {} as a fallback when bindings-config output is empty or unset. Windows ARM64 retains its existing single-CUDA-major label selection.
Suggested reviewers:leofang, isvoid
Change: Bug fix
Merge Risk: Minimal · up to 2d321
This CI-only change lets build job names evaluate when the configuration job is skipped, so the workflow can conclude as skipped. Normal job names and build behavior are unchanged, and no merge-blocking risk is evident.
Architecture risk: Low · up to 2d321
The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.
Changed systems: None identified.
Architecture concerns
No architecture-level concerns identified.
Review details
Before / after behavior
observed — Modified behavior in .github/workflows/ci.yml: The Linux build name now falls back to an empty JSON object when bindings-config is empty or unset before reading package toolkit versions.
observed — Modified behavior in .github/workflows/ci.yml: The Linux ARM64 build name now falls back to an empty JSON object when bindings-config is empty or unset before reading package toolkit versions.
observed — Modified behavior in .github/workflows/ci.yml: The Windows build name now falls back to an empty JSON object when bindings-config is empty or unset before reading package toolkit versions.
observed — Modified behavior in .github/workflows/ci.yml: The Windows ARM64 build name now uses the same empty-object fallback when bindings-config is empty or unset; its existing single-CUDA-major label selection is unchanged.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between d768d2d and 2d321a0.
Files selected for processing: 1
.github/workflows/ci.yml
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
Preview will be ready when the GitHub Pages deployment is complete.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
— codex on behalf of Ralf —
Description
CI intentionally skips its NVIDIA-only jobs in forks. However, GitHub can still evaluate the four build-job display names, which parse
detect-changes.outputs.bindings-configusingfromJSON. Whendetect-changesis skipped, that output is empty, and parsing it can turn an intentionally skipped workflow into a failed run.Add an empty-object fallback in those four display-name expressions so the workflow can conclude
skippedas intended. The fallback affects display names only; build configuration, matrices, execution conditions, and normal job names remain unchanged.xref: ctk-next PR 850
Validation
SKIP=lychee pre-commit run --all-filespassed, including actionlint.skipped.Checklist