[no-ci] ci: build and test local CUDA 12 bindings by rwgk · Pull Request #3317 · NVIDIA/cuda-python

rwgk · 2026-10-31T05:13:10Z

— codex GPT-6 on behalf of Ralf —

Layer 3 of 7 of the staged "CUDA 12 bindings on main" stack. Previous: #3315. Next: #3318. Stack map at the bottom.

Merge sequencing: land the five remaining migration PRs together using the atomic stack merge described in the landing plan.

What this PR does

main starts building the CUDA 12 bindings wheel itself and running its GPU test suite, next to the existing CUDA 13 pipeline. Nothing else moves yet: cuda.core and the metapackage keep consuming the 12.9.x-branch artifacts (that cord is cut in #3318).

build-wheel.yml: after the CUDA 13 work, switch to the maintenance mini-CTK (already fetched for Core's cu12 half), build the cuda_bindings_12 wheel with the same cibuildwheel environment (shared through a YAML anchor), twine check it, upload it, and build and upload its Cython test extensions.
ci.yml: three new jobs, Maintenance bindings (linux-64 / linux-aarch64 / win-64), call the existing test workflows with maintenance-bindings: true. Only matrix rows with CUDA_VER == 12.9.1 run, and only the bindings suite.
test-wheel-linux.yml, test-wheel-windows.yml: new inputs bindings-config and maintenance-bindings; rows gain BINDINGS_ROOT.
ci/tools/env-vars, ci/tools/run-tests: CUDA_BINDINGS_ROOT replaces the hard-coded cuda_bindings_13.
cuda_bindings_12/pyproject.toml: wheel payload policy copied from CUDA 13 (include-package-data = false: wheels ship .pxd/.pxi and headers, not .pyx sources or .in templates; sdists keep everything) and cibuildwheel settings. Recorded in the upcoming release notes.

Temporary scaffolding: the artifact name maintenance-bindings-python<py>-cuda12.9.1-<platform>-<sha> and the three jobs exist only in this layer. #3318 folds the tests into the regular jobs and #3319 renames the artifacts to the final cuda-bindings-python<py>-cuda<toolkit>-... scheme.

After this merges

Every CI run additionally builds one CUDA 12 bindings wheel per Python version and platform (no Windows ARM64; CUDA 12 has no toolkit there) and runs the bindings suite on the matrix rows whose toolkit is 12.9.1 (a few extra GPU jobs per platform).
cuda.core, the metapackage, releases, and nightly are unchanged.

Where to look

.github/workflows/build-wheel.yml: the "maintenance cuda.bindings" steps near the bottom and the &bindings-wheel-env anchor.
.github/workflows/test-wheel-linux.yml: the maintenance-bindings matrix filter (the Windows file mirrors it).
cuda_bindings_12/pyproject.toml: the payload policy, a deliberate product decision.

All changes (8 files, +254 / -19)

.github/workflows/build-wheel.yml: maintenance wheel build/check/upload, Cython test build/upload, mini-CTK gating.
.github/workflows/ci.yml: ci-vars exports the registry JSON; three test-maintenance-bindings-* jobs; the checks aggregator expects them.
.github/workflows/test-wheel-linux.yml, test-wheel-windows.yml: bindings-config / maintenance-bindings inputs, matrix filter, artifact prefix.
ci/tools/env-vars: MAINTENANCE_* build variables, CUDA_BINDINGS_ROOT, artifact prefix.
ci/tools/run-tests: bindings suite runs from CUDA_BINDINGS_ROOT.
cuda_bindings_12/pyproject.toml, docs/source/release/12.X.Y-notes.rst: payload policy and its note.

Validation

Full CI passed at the pre-rebase head afe9fc9e (run 41185002774), including the three new maintenance-bindings jobs.
Local validation at 9794e83edb7875a53849f562a17043cf79d88797: 316 CI-tool tests and configured workflow lint passed. Full-stack CI on #3322 passed at 126ed74fb5bbfbc91a04e50557cf936efef4da7f (105 successful jobs; one expected skip).

Stack map: cumulative capabilities by layer

Layer	PR	Capability added
1	#3314	behaves exactly as before; CI has one reader for the two bindings roots; CUDA 13 versions can no longer match a `v12.*` tag
2	#3315	lets a developer build, test, and document `cuda_bindings_12/`; the PR-time CPU source-build smoke covers both roots; three CUDA 12 runtime fixes are in
3	#3317	builds the CUDA 12 bindings wheel itself and runs its GPU tests; `cuda.core` and the metapackage still consume `12.9.x` artifacts
4	#3318	uses same-run CUDA 12 wheels everywhere; PR CI no longer reads the `12.9.x` branch
5	#3319	can release CUDA 12 from a `v12.9.N` tag on `main`; CUDA 13 releases are unchanged
6	#3321	builds and tests only what a change needs, per bindings root, reusing baseline artifacts
7	#3322	adopts the schema-2 registry, removes backport automation, adds metadata checks and maintenance docs; `12.9.x` is frozen

Layers #3314 and #3315 have merged. The remaining five migration PRs (#3317, #3318, #3319, #3321 and #3322) will land together using GitHub’s atomic stack merge, with full CI on #3322 as described in the landing plan. #3434 follows separately, after a successful post-migration main CI run supplies complete artifacts for both CUDA majors.

copy-pr-bot · 2026-10-31T05:13:14Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

rwgk · 2026-10-31T08:32:06Z

/ok to test afe9fc9

github-actions · 2026-10-31T08:48:34Z

Doc Preview CI
🚀 View preview at https://nvidia.github.io/cuda-python/pr-preview/pr-3317/
https://nvidia.github.io/cuda-python/pr-preview/pr-3317/cuda-core/
https://nvidia.github.io/cuda-python/pr-preview/pr-3317/cuda-bindings/
https://nvidia.github.io/cuda-python/pr-preview/pr-3317/cuda-pathfinder/
Preview will be ready when the GitHub Pages deployment is complete.

mdboom

This PR is a bit of a special case to call it out. It adds things that we wouldn't want permanently that subsequence steps remove, really to just "bootstrap" the wheels into the right place. It would be better if there were a way to bootstrap in a single step because this will put us on a path to merge each of these individually.

I think a better arrangement would be to have a lower-level wheel-building workflow for specific wheels that could be triggered manually. Then for bootstrapping, we kick it off directly, and otherwise it would just be used in various configurations from the existing build-wheel.yml script. But that's probably not worth it.

🔴 JUST AN IMPORTANT NOTE TO MAKE SURE THE STACK ABOVE THIS IS APPROVED BEFORE MERGING THIS SO WE DON'T GET STUCK IN THIS BAD INTERMEDIATE STATE.

mdboom · 2026-11-03T16:34:14Z

+      - name: Prepare local maintenance SCM milestone
+        if: ${{ !inputs.single-cuda-major && (env.BUILD_BINDINGS == 'true' || env.TEST_BINDINGS == 'true') }}
+        run: |
+          python -m ci.tools.bindings_scm_version \


See my previous comments in #3315 and #3316 about bindings_scm_version.

— codex GPT-6 on behalf of Ralf —

This caller is now removed as part of the common bootstrap cleanup. The retained v12.9.11a0 milestone is on main and both alternatives are restacked onto it, as recorded in the updated #3315 reply.

mdboom · 2026-11-03T16:38:13Z

+      - name: Set up Python for CI tools
+        uses: ./.github/actions/setup-hardened-python
+        with:
+          python-version: "3.12"


Again, 3.12 is an odd choice. 3.11 would be better.

— codex GPT-6 on behalf of Ralf —

Changed this tooling job to Python 3.11. implementation.

mdboom · 2026-11-03T16:39:53Z

+      bindings-only:
+        description: Test this run's maintenance bindings wheel and Cython extensions.
+        type: boolean
+        default: false


bindings-only is a confusing name for this variable (if the comment is correct). Maybe maintenance-bindings?

— codex GPT-6 on behalf of Ralf —

Renamed the temporary input to maintenance-bindings in both reusable workflows and their callers. implementation; callers.

rwgk

— codex GPT-6 on behalf of Ralf —

Thanks for calling out the intermediate-state risk in your review. The PR description now explicitly requires approval of the upper stack before this temporary bridge merges. I kept the existing bridge rather than introducing another wheel-building workflow.

All three inline comments now have direct replies. The Python/input-name changes are applied. The retained v12.9.11a0 milestone is now on main; both alternatives are restacked onto it, and the bootstrap helper, tests, metadata and callers are removed.

rwgk · 2026-11-06T09:05:07Z

/ok to test 9df7fc6

mdboom

LGTM

mdboom · 2026-11-06T19:01:23Z

+      nruns: ${{ (github.event_name == 'schedule' && 5) || 1 }}
+      workplan: ${{ needs.detect-changes.outputs.workplan }}
+
+  test-maintenance-bindings-windows:


Minor nit: We don't need both x86 and arm for windows on the maintenance build today, but when we move from 12/13 to 13/14 we will need to add Windows on ARM here, so maybe add a comment?

copy-pr-bot · 2026-11-07T17:49:12Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

coderabbitai · 2026-11-08T07:26:08Z

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

New Features
- Added maintenance-version CUDA bindings wheel builds and automated tests for supported Linux and Windows platforms.
Documentation
- Clarified that wheels include Cython declarations and required headers but omit implementation sources and generation templates; source distributions retain the inputs needed to build the package.
Chores
- Updated wheel packaging settings, including Windows wheel repair and Linux build compatibility, and improved caching for bindings builds.

The CI workflows now build prior-major maintenance cuda.bindings wheels and run bindings tests on Linux and Windows. The CUDA 12 package configuration defines wheel contents and build settings. Release notes describe the packaged files.

Changes: Maintenance cuda.bindings pipeline

Layer / File(s)	Summary
CUDA 12 wheel packaging `cuda_bindings_12/pyproject.toml`, `cuda_bindings_12/docs/source/release/12.X.Y-notes.rst`	The package configuration specifies included Cython declarations and headers, wheel platforms, and Windows repair. The release notes describe wheel and source distribution contents.
Maintenance wheel build and Cython artifacts `.github/workflows/build-wheel.yml`, `ci/tools/env-vars`, `ci/tools/run-tests`	When prior-major builds are enabled, the workflow builds and checks a maintenance wheel for bindings builds or tests. For bindings tests, it installs that wheel, builds Cython tests, and uploads the artifacts. The environment scripts resolve maintenance package paths and artifact names.
Maintenance test matrix and CI orchestration `.github/workflows/ci.yml`, `.github/workflows/test-wheel-linux.yml`, `.github/workflows/test-wheel-windows.yml`, `ci/tools/env-vars`, `ci/tools/run-tests`	Maintenance mode selects package roots by toolkit version and runs bindings tests only. The CI workflow schedules maintenance test jobs for Linux x86-64, Linux AArch64, and Windows, then checks their expected results.

Possibly related issues

NVIDIA/cuda-python#3402 — The issue asks for a shared Core wheel-build implementation. This PR adds maintenance bindings wheel steps to the same workflow but does not extract that implementation.

Possibly related PRs

NVIDIA/cuda-python#3321 — It changes the build and bindings routing contracts used by this PR’s maintenance workflow.
NVIDIA/cuda-python#3318 — It changes maintenance-bindings inputs, build conditions, and environment variables also changed here.
NVIDIA/cuda-python#3322 — It revises the registry and artifact paths used by this maintenance flow.

Suggested reviewers: leofang, jpascucci-nv

Change: Other

Merge Risk: Minimal · up to d179c

This change adds CUDA 12 bindings wheel builds and tests to CI alongside the CUDA 13 pipeline. No concrete merge-blocking defect was found in the supplied review context.

Architecture risk: Low · up to d179c

The change affects 2 systems.

Changed systems: ci, cuda_bindings_12

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — ci (service) was modified; 2 changed files map to changed impact.
observed — cuda_bindings_12 (service) was modified; 2 changed files map to changed impact.

Before / after behavior

observed — Modified behavior in ci/tools/env-vars: Adds defaults for the bindings package root and artifact-name prefix; existing environment values take precedence.
observed — Modified behavior in ci/tools/env-vars: Build mode queries ci.tools.bindings_config for the maintenance release’s package root and toolkit version, then exports those values, resolved distribution and Cython-test paths, and an artifact name containing the Python version, toolkit version, platform, and SHA.
observed — Modified behavior in ci/tools/env-vars: The test-mode bindings artifact basename now uses BINDINGS_ARTIFACT_PREFIX instead of the fixed cuda-bindings prefix.
observed — Modified behavior in ci/tools/env-vars: The exported bindings artifact and Cython-test directories now resolve beneath CUDA_BINDINGS_ROOT instead of the fixed cuda_bindings_13 path.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

Source mode: Auto

Repository: NVIDIA/cuda-python

Branch: main

File: .coderabbit.yaml

Commit: b715078

Layers: Repository YAML

Review profile: CHILL

Plan: Enterprise

Run ID: `9eaf1a10-1a67-4e05-a5a9-5cfa65dd4dc9`

Commits

Reviewing files that changed from the base of the PR and between `c707f8f` and `d179cd9`.

Files selected for processing: 1

`.github/workflows/build-wheel.yml`

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

coderabbitai

Additional comments: 1

.github/workflows/build-wheel.yml: 1

563-563: Trivial · Maintainability & Code Quality · Low value

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

suggestion: This step pins pypa/cibuildwheel at v4.3.4 (b9e566a2). The other cibuildwheel steps in this file pin v4.3.5 (f9b966cf). Use the same pin for all steps so the CUDA 12 and CUDA 13 wheels build with one tool version. If the older pin is intentional, add a comment that says why.

Review info

Run configuration

Source mode: Auto

Repository: NVIDIA/cuda-python

Branch: main

File: .coderabbit.yaml

Commit: db463bf

Layers: Repository YAML

Review profile: CHILL

Plan: Enterprise

Run ID: `20e21f90-06f3-4b7b-8955-19b95b1e88c6`

Commits

Reviewing files that changed from the base of the PR and between `db463bf` and `8728407`.

Files selected for processing: 8

`.github/workflows/build-wheel.yml`

`.github/workflows/ci.yml`

`.github/workflows/test-wheel-linux.yml`

`.github/workflows/test-wheel-windows.yml`

`ci/tools/env-vars`

`ci/tools/run-tests`

`cuda_bindings_12/docs/source/release/12.X.Y-notes.rst`

`cuda_bindings_12/pyproject.toml`

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 8 remain after this review.

rwgk · 2026-11-09T00:16:03Z

— codex GPT-6 on behalf of Ralf —

Addressed the cibuildwheel pin mismatch from this review in this update. The existing v4.3.5 alignment now belongs to this layer, so the CUDA 12 and CUDA 13 builders use the same version throughout the remaining stack.

rwgk · 2026-11-09T00:42:42Z

/ok to test 40a5cb8

Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>

rwgk · 2026-11-13T03:06:09Z

/ok to test d179cd9

rwgk added this pull request to stack #3316 October 31, 2026 05:13

github-actions Bot added CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module labels Oct 31, 2026

rwgk added this to the cuda.bindings next milestone Oct 31, 2026

rwgk added the enhancement Any code-related improvements label Oct 31, 2026

rwgk self-assigned this Oct 31, 2026

rwgk force-pushed the rwgk/cb12-staged-03-bindings-ci branch 4 times, most recently from 97d969c to afe9fc9 Compare October 31, 2026 08:03

rwgk force-pushed the rwgk/cb12-staged-03-bindings-ci branch from afe9fc9 to 40bc259 Compare November 1, 2026 22:38

rwgk force-pushed the rwgk/cb12-staged-03-bindings-ci branch from 40bc259 to 24d485d Compare November 2, 2026 03:53

mdboom requested changes Nov 3, 2026

View reviewed changes

rwgk force-pushed the rwgk/cb12-staged-03-bindings-ci branch from 24d485d to 9794e83 Compare November 4, 2026 06:08

rwgk commented Nov 4, 2026

View reviewed changes

rwgk force-pushed the rwgk/cb12-staged-03-bindings-ci branch from 9df7fc6 to 02c3828 Compare November 6, 2026 18:02

mdboom approved these changes Nov 6, 2026

View reviewed changes

Base automatically changed from rwgk/cb12-staged-02-developer to main November 6, 2026 19:28

rwgk force-pushed the rwgk/cb12-staged-03-bindings-ci branch 2 times, most recently from 3c848c4 to 8728407 Compare November 7, 2026 17:49

rwgk marked this pull request as ready for review November 8, 2026 07:17

coderabbitai Bot reviewed Nov 8, 2026

View reviewed changes

rwgk changed the title ~~ci: build and test local CUDA 12 bindings~~ [no-ci] ci: build and test local CUDA 12 bindings Nov 12, 2026

rwgk force-pushed the rwgk/cb12-staged-03-bindings-ci branch from 40a5cb8 to c707f8f Compare November 12, 2026 21:18

rwgk added 5 commits November 12, 2026 18:57

ci: build and test local CUDA 12 bindings

4a95cae

Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>

docs: note the CUDA 12 wheel payload change

a68439f

Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>

Address migration review: simplify configuration and tooling

27abc34

Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>

Use retained CUDA 12 milestone for wheel builds

2f564c3

Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>

ci: align maintenance cibuildwheel with the current builder

d179cd9

rwgk force-pushed the rwgk/cb12-staged-03-bindings-ci branch from c707f8f to d179cd9 Compare November 13, 2026 03:04

rwgk merged commit 0ce9436 into main Nov 13, 2026
34 checks passed

rwgk deleted the rwgk/cb12-staged-03-bindings-ci branch November 13, 2026 05:25

Conversation

rwgk commented Oct 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does

After this merges

Where to look

Uh oh!

copy-pr-bot Bot commented Oct 31, 2026

Uh oh!

rwgk commented Oct 31, 2026

Uh oh!

github-actions Bot commented Oct 31, 2026

Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

mdboom left a comment

Choose a reason for hiding this comment

Uh oh!

mdboom Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

rwgk Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdboom Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

rwgk Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

mdboom Nov 3, 2026

Choose a reason for hiding this comment

Uh oh!

rwgk Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

rwgk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rwgk commented Nov 6, 2026

Uh oh!

mdboom left a comment

Choose a reason for hiding this comment

Uh oh!

mdboom Nov 6, 2026

Choose a reason for hiding this comment

Uh oh!

copy-pr-bot Bot commented Nov 7, 2026

Uh oh!

coderabbitai Bot commented Nov 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

rwgk commented Nov 9, 2026

Uh oh!

rwgk commented Nov 9, 2026

Uh oh!

rwgk commented Nov 13, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rwgk commented Oct 31, 2026 •

edited

Loading

rwgk Nov 4, 2026 •

edited

Loading

rwgk left a comment •

edited

Loading

coderabbitai Bot commented Nov 8, 2026 •

edited

Loading