Repository navigation
cuda.core: expose last prefetch location on ManagedBuffer - #2774
Conversation
|
/ok to test |
@isVoid, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
|
/ok to test 08b4cf4 |
| from cuda.core._utils.version import binding_version, driver_version | ||
|
|
||
| if binding_version() < (13, 0, 0) or driver_version() < (13, 0, 0): | ||
| pytest.skip("Host NUMA last-prefetch location requires CUDA 13") |
There was a problem hiding this comment.
I've been trained to lean towards skipping at collection time. Worth doing here?
There was a problem hiding this comment.
Not sure if there are any order requirement at test collecting time and initializing CUDA. Let me check with my agent to see if possible.
brandon-b-miller
left a comment
brandon-b-miller
left a comment
There was a problem hiding this comment.
Overall looks good. Based on what happened when this features sibling attrs were introduced, I infer that we may need a release notes entry documenting this new feature.
|
/ok to test afb0334 |
|
/ok to test bcf63da |
This comment has been minimized.
This comment has been minimized.
|
Description
closes #2109
Expose the read-only
ManagedBuffer.last_prefetch_locationproperty.Device,Host, orNone.LAST_PREFETCH_LOCATION_TYPE/_IDpair so NUMA host locations round-trip.Testing
cd cuda_core && pixi run -e cu13 pytest tests/memory/test_managed_ops.py -q— 37 passed, 1 skippedcd cuda_core && pixi run -e cu12 pytest tests/memory/test_managed_ops.py -q— 16 passed, 22 skippedChecklist