Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b1b6070
CI: allow specifying custom driver versions in test matrix
leofang Jun 7, 2026
3e016b5
CI: fix Linux driver nsenter re-exec, swap Windows version, enable ci…
leofang Jun 7, 2026
c0ca869
CI: move 'Ensure GPU is working' after 'Install GPU driver' on Linux
leofang Jun 7, 2026
4a23b23
CI: flip two PR-matrix Linux rows to DRIVER=610.43.02
leofang Jun 7, 2026
d33a928
CI: restart nvidia-persistenced on Linux; poll nvidia-smi on Windows
leofang Jun 7, 2026
00896dc
CI: re-enable persistence mode after Linux driver swap
leofang Jun 7, 2026
0d5f0e9
CI: preserve SUID bit when refreshing container nvidia binaries
leofang Jun 7, 2026
3dfaa84
CI: exec nvidia-persistenced directly after Linux driver swap
leofang Jun 7, 2026
701cf2f
CI: pass --user root to nvidia-persistenced after Linux driver swap
leofang Jun 7, 2026
a3f1573
CI: add fast-feedback probe-driver-swap job (workflow_dispatch only)
leofang Jun 7, 2026
c5fef92
CI: drop workflow_dispatch gate on probe-driver-swap so it runs on ev…
leofang Jun 7, 2026
f17dd7f
CI: stop refresh_container_libs from clobbering /run/nvidia-persistenced
leofang Jun 7, 2026
6412f4f
CI: take down nvidia-persistenced via pkill, not systemctl
leofang Jun 7, 2026
2b34f1f
CI: re-bind /run/nvidia-persistenced into container after driver swap
leofang Jun 7, 2026
8d8a9ef
CI: drop install_gpu_driver.sh experiments that turned out non-load-b…
leofang Jun 7, 2026
d2c25eb
Revert: remove the probe-driver-swap fast-feedback job
leofang Jun 7, 2026
fa7940a
CI: address Mike's review comments on PR 2176
leofang Jun 8, 2026
8dfd06e
Merge branch 'main' into leof/ci-custom-driver-versions
leofang Jun 9, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CI: address Mike's review comments on PR 2176
- ci.yml: `workflow_dispatch:` -> `workflow_dispatch: {}` so the empty
  mapping reads as intentional rather than ambiguous YAML.
- test-wheel-linux.yml: declare `util-linux` in `Install dependencies`
  instead of running a second apt-get inline; util-linux ships in
  ubuntu:22.04 by default so this is mostly belt-and-suspenders, but
  it removes the redundant apt-get call.
- install_gpu_driver.sh: drop `2>/dev/null` on `systemctl stop` so
  real errors surface (`|| true` keeps the script non-fatal). The
  redirect was inherited verbatim from nv-gha-runners/vm-images PR 256
  with no specific need.
  • Loading branch information
leofang committed Jun 8, 2026
commit fa7940aecd2be6f8104d41156de12ebfa00a43f6
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:
schedule:
# every 24 hours at midnight UTC
- cron: "0 0 * * *"
workflow_dispatch:
workflow_dispatch: {}

jobs:
ci-vars:
Expand Down
13 changes: 5 additions & 8 deletions .github/workflows/test-wheel-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,21 +132,18 @@ jobs:
uses: ./.github/actions/install_unix_deps
continue-on-error: false
with:
# for artifact fetching, graphics libs, g++ required for cffi in example
dependencies: "jq wget libgl1 libegl1 g++"
# for artifact fetching, graphics libs, g++ required for cffi in
# example; util-linux for `nsenter` (custom-DRIVER rows re-exec
# install_gpu_driver.sh onto the host through nsenter)
dependencies: "jq wget libgl1 libegl1 g++ util-linux"
dependent_exes: "jq wget"

- name: Install GPU driver
if: ${{ matrix.DRIVER != 'latest' && matrix.DRIVER != 'earliest' }}
env:
DRIVER: ${{ matrix.DRIVER }}
GPU_TYPE: ${{ matrix.GPU }}
Comment thread
leofang marked this conversation as resolved.
Resolved
run: |
# util-linux for nsenter; install_gpu_driver.sh re-execs onto the
# host (requires --privileged --pid=host on the container, set
# conditionally above) and refreshes the toolkit bind mounts here.
apt-get -y install --no-install-recommends util-linux
./ci/tools/install_gpu_driver.sh
run: ./ci/tools/install_gpu_driver.sh

- name: Ensure GPU is working
run: nvidia-smi
Expand Down
2 changes: 1 addition & 1 deletion ci/tools/install_gpu_driver.sh
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ in_container() {
host_install() {
apt-get -y install build-essential dkms "linux-headers-$(uname -r)" psmisc kmod

systemctl stop nvidia-persistenced dcgm-exporter 2>/dev/null || true
systemctl stop nvidia-persistenced dcgm-exporter || true
# if-test instead of `fuser ... || true` so a kill failure surfaces
# (fuser exits 1 when nothing holds the device, which is the happy path).
if fuser /dev/nvidia* >/dev/null 2>&1; then
Expand Down
Loading