Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add TODO comments for all Python 3.15 workarounds
Mark every temporary 3.15 hack (version-gated deps, numpy pre-build,
continue-on-error, allow-prereleases, cpython-prerelease, release
exclusion) with a TODO so they are easy to find and remove once 3.15
is officially supported.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
  • Loading branch information
leofang and claude committed Jun 5, 2026
commit 839f78579ec01ff9aea74ee67434287c06b9285a
6 changes: 6 additions & 0 deletions .github/workflows/build-wheel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ jobs:
output-dir: ${{ env.CUDA_BINDINGS_ARTIFACTS_DIR }}
env:
CIBW_BUILD: ${{ env.CIBW_BUILD }}
# TODO: remove cpython-prerelease once 3.15 is officially supported
# Allow CPython pre-release builds (currently 3.15 / 3.15t). This is a
# no-op for stable Python versions because CIBW_BUILD still filters
# the target version.
Expand Down Expand Up @@ -238,6 +239,7 @@ jobs:
output-dir: ${{ env.CUDA_CORE_ARTIFACTS_DIR }}
env:
CIBW_BUILD: ${{ env.CIBW_BUILD }}
# TODO: remove cpython-prerelease once 3.15 is officially supported
# Allow CPython pre-release builds (currently 3.15 / 3.15t). This is a
# no-op for stable Python versions because CIBW_BUILD still filters
# the target version.
Expand Down Expand Up @@ -337,6 +339,7 @@ jobs:
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: ${{ matrix.python-version }}
# TODO: remove allow-prereleases once 3.15 is officially supported
allow-prereleases: ${{ startsWith(matrix.python-version, '3.15') }}

- name: verify free-threaded build
Expand Down Expand Up @@ -364,6 +367,8 @@ jobs:
mv "/c/Program Files/Git/usr/bin/link.exe" "/c/Program Files/Git/usr/bin/link.exe.bak"
fi

# TODO: remove the numpy pre-build steps once 3.15 is officially supported
# (numpy will publish pre-built 3.15 wheels at that point)
- name: Download and patch numpy sdist (pre-release Python)
if: ${{ startsWith(matrix.python-version, '3.15') }}
run: |
Expand Down Expand Up @@ -491,6 +496,7 @@ jobs:
output-dir: ${{ env.CUDA_CORE_ARTIFACTS_DIR }}
env:
CIBW_BUILD: ${{ env.CIBW_BUILD }}
# TODO: remove cpython-prerelease once 3.15 is officially supported
# Allow CPython pre-release builds (currently 3.15 / 3.15t). This is a
# no-op for stable Python versions because CIBW_BUILD still filters
# the target version.
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test-wheel-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ jobs:
fail-fast: false
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
runs-on: "${{ matrix.FLAVOR || 'linux' }}-${{ matrix.ARCH }}-gpu-${{ matrix.GPU }}-${{ matrix.DRIVER }}-${{ matrix.GPU_COUNT }}"
# TODO: remove continue-on-error once 3.15 is officially supported
continue-on-error: ${{ startsWith(matrix.PY_VER, '3.15') }}
# The build stage could fail but we want the CI to keep moving.
if: ${{ github.repository_owner == 'nvidia' && !cancelled() }}
Expand Down Expand Up @@ -259,6 +260,7 @@ jobs:
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: ${{ matrix.PY_VER }}
# TODO: remove allow-prereleases once 3.15 is officially supported
allow-prereleases: ${{ startsWith(matrix.PY_VER, '3.15') }}
env:
# we use self-hosted runners on which setup-python behaves weirdly (Python include can't be found)...
Expand All @@ -272,6 +274,7 @@ jobs:
host-platform: ${{ inputs.host-platform }}
cuda-version: ${{ matrix.CUDA_VER }}

# TODO: remove the numpy wheel steps once 3.15 is officially supported
- name: Download numpy wheel (pre-release Python)
if: ${{ startsWith(matrix.PY_VER, '3.15') }}
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-wheel-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ jobs:
fail-fast: false
matrix: ${{ fromJSON(needs.compute-matrix.outputs.MATRIX) }}
if: ${{ github.repository_owner == 'nvidia' && !cancelled() }}
# TODO: remove continue-on-error once 3.15 is officially supported
continue-on-error: ${{ startsWith(matrix.PY_VER, '3.15') }}
runs-on: "windows-${{ matrix.ARCH }}-gpu-${{ matrix.GPU }}-${{ matrix.DRIVER }}-${{ matrix.GPU_COUNT }}"
steps:
Expand Down Expand Up @@ -263,6 +264,7 @@ jobs:
host-platform: ${{ inputs.host-platform }}
cuda-version: ${{ matrix.CUDA_VER }}

# TODO: remove the numpy wheel steps once 3.15 is officially supported
- name: Download numpy wheel (pre-release Python)
if: ${{ startsWith(matrix.PY_VER, '3.15') }}
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
Expand Down
1 change: 1 addition & 0 deletions ci/tools/download-wheels
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ do
continue
fi

# TODO: remove the Python 3.15 exclusion once 3.15 is officially supported
# exclude pre-release Python (3.15) wheels from releasing
if [[ "${p}" == *python315* ]]; then
echo "Skipping pre-release Python artifact: $p"
Expand Down
1 change: 1 addition & 0 deletions cuda_bindings/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ all = [
test = [
"cython>=3.2,<3.3",
"setuptools>=77.0.0",
# TODO: remove the Python 3.15 guard once 3.15 is officially supported
"matplotlib>=3.5.0; python_version < '3.15'",
"numpy>=1.21.1",
"pytest>=6.2.4",
Expand Down
8 changes: 7 additions & 1 deletion cuda_core/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,13 @@ cu12 = ["cuda-bindings[all]==12.*", "cuda-toolkit==12.*"]
cu13 = ["cuda-bindings[all]==13.*", "cuda-toolkit==13.*"]

[dependency-groups]
test = ["cython>=3.2,<3.3", "setuptools", "pytest>=6.2.4", "pytest-benchmark", "pytest-randomly", "pytest-repeat", "pytest-rerunfailures", "pytest-timeout", "cloudpickle", "psutil", "cffi; python_version < '3.15'"]
test = [
"cython>=3.2,<3.3", "setuptools", "pytest>=6.2.4", "pytest-benchmark",
"pytest-randomly", "pytest-repeat", "pytest-rerunfailures", "pytest-timeout",
"cloudpickle", "psutil",
# TODO: remove the Python 3.15 guard once 3.15 is officially supported
"cffi; python_version < '3.15'",
]
ml-dtypes = ["ml-dtypes>=0.5.4,<0.6.0"]
test-cu12 = [ {include-group = "ml-dtypes" }, {include-group = "test" }, "cupy-cuda12x; python_version < '3.14'", "cuda-toolkit[cudart]==12.*"] # runtime headers needed by CuPy
test-cu13 = [ {include-group = "ml-dtypes" }, {include-group = "test" }, "cupy-cuda13x; python_version < '3.14'", "cuda-toolkit[cudart]==13.*"] # runtime headers needed by CuPy
Expand Down
1 change: 1 addition & 0 deletions cuda_pathfinder/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ cu13 = [
"nvidia-nvshmem-cu13; sys_platform != 'win32'",
]
host = [
# TODO: remove the Python 3.15 guard once 3.15 is officially supported
"nvidia-cutlass; python_version < '3.15'",
"nvpl-fft; platform_system == 'Linux' and platform_machine == 'aarch64'",
]
Expand Down
Loading