CI: Require all checks passing before merging

It has come to my attention that we can have PRs merged without all CI pipelines passing. Since 1. we have working CIs now, and 2. we've fixed the flaky build failures (#271), I ask that we enforce the CI checks being run & green before any PR gets merged.

Unfortunately, the GitHub built-in "required status check" is pretty crappy and useless (https://github.com/orgs/community/discussions/13690). We'll need an alternative. I see that our org admin has approved the usage of this action: https://github.com/poseidon/wait-for-status-checks. I suggest that we give it a shot.

cc @NVIDIA/cuda-python-dev for vis

#379 seems to be working now 🎉 What happens now is:

I added the status-check job to the Required Status Check field in the branch rule (main for now)

Any PR would have the status check shown "waiting for status to be reported")

Once CI is run, and all CI pipelines pass, it'd turn green

#379 seems to be working now 🎉 What happens now is:

I added the status-check job to the Required Status Check field in the branch rule (main for now)

The status check was backported in #382 and both main and 11.8.x branches require all CI jobs to pass now.

[celebrate] Emily Zhao reacted to your message:

…

________________________________ From: Leo Fang ***@***.***> Sent: Sunday, January 12, 2025 9:14:51 PM To: NVIDIA/cuda-python ***@***.***> Cc: Emily Zhao ***@***.***>; Team mention ***@***.***> Subject: Re: [NVIDIA/cuda-python] CI: Require all checks passing before merging (Issue #377) #379<#379> seems to be working now 🎉 What happens now is: 1. I added the status-check job to the Required Status Check field in the branch rule (main for now) The status check was backported in #382<#382> and both main and 11.8.x branches require all CI jobs to pass now. — Reply to this email directly, view it on GitHub<#377 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BINCDWCEFM5HS5CMNJ4SB5D2KLLMXAVCNFSM6AAAAABU7G6KP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVHEYTQNZYGM>. You are receiving this because you are on a team that was mentioned.Message ID: ***@***.***>

Navigation Menu

Repository navigation

CI: Require all checks passing before merging #377

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

CI: Require all checks passing before merging #377

Description

Activity

leofang commented on Jan 12, 2025

leofang commented on Jan 12, 2025

jollylili commented on Jan 13, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions