Skip to content

Commit bc92709

Browse files
committed
CI: Point CTK version bumps at the redistrib manifest pins
Note in ci/versions.yml that each CUDA version there and in LOCAL_CTK matrix rows needs a pin in KNOWN_REDISTRIB_SHA256, and make the coverage test's failure message say where to add the pin and how to compute it.
1 parent baa5ab6 commit bc92709

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

‎ci/tools/tests/test_fetch_ctk_redistrib.py‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,12 @@ def test_known_redistrib_sha256_covers_ci_cuda_versions():
130130
if str(row.get("LOCAL_CTK")) == "1"
131131
}
132132
assert required
133-
assert sorted(required - KNOWN_REDISTRIB_SHA256.keys()) == []
133+
missing = sorted(required - KNOWN_REDISTRIB_SHA256.keys())
134+
assert not missing, (
135+
f"CUDA versions used by CI have no pinned redistrib manifest hash: {missing}. "
136+
"Add them to KNOWN_REDISTRIB_SHA256 in ci/tools/fetch_ctk_redistrib.py; compute each hash with "
137+
"`curl -fsSL https://developer.download.nvidia.com/compute/cuda/redist/redistrib_<ver>.json | sha256sum`."
138+
)
134139
for version, sha256 in KNOWN_REDISTRIB_SHA256.items():
135140
assert SHA256_RE.fullmatch(sha256), f"invalid pinned sha256 for CUDA {version}"
136141

‎ci/versions.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ backport_branch: "12.9.x" # keep in sync with target-branch in .github/dependab
66
# This controls the version of the upstream CTK to install to build the wheels.
77
# It is not the version of cuda_bindings/cuda_python being released, which is
88
# solely determined by git tags via setuptools_scm.
9+
# Each version here, and in every LOCAL_CTK: '1' row of ci/test-matrix.yml,
10+
# needs a pinned manifest hash in KNOWN_REDISTRIB_SHA256 in
11+
# ci/tools/fetch_ctk_redistrib.py; fetch_ctk fails without one.
912
cuda:
1013
build:
1114
version: "13.5.0"

0 commit comments

Comments
 (0)