Skip to content

Commit b574e83

Browse files
juenglinjuenglin
committed
ci: drop dummy cibuildwheel tests used only for sccache stats
Dump sccache during Linux wheel repair instead of installing the wheel just to echo ok. UV_CONSTRAINT is unused without that test install.
1 parent 7aa10b7 commit b574e83

1 file changed

Lines changed: 14 additions & 32 deletions

File tree

‎.github/workflows/build-wheel.yml‎

Lines changed: 14 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,6 @@ jobs:
238238
CUDA_PATH=/host/${{ env.CUDA_PATH }}
239239
CUDA_PYTHON_PARALLEL_LEVEL=${{ env.CUDA_PYTHON_PARALLEL_LEVEL }}
240240
UV_BUILD_CONSTRAINT=/host/${{ github.workspace }}/wheel-constraints/cuda-bindings.txt
241-
UV_CONSTRAINT=/host/${{ github.workspace }}/wheel-constraints/cuda-bindings.txt
242241
CC="/host/${{ env.SCCACHE_PATH }} cc"
243242
CXX="/host/${{ env.SCCACHE_PATH }} c++"
244243
SCCACHE_GHA_ENABLED=true
@@ -251,16 +250,11 @@ jobs:
251250
CUDA_PATH="$(cygpath -w ${{ env.CUDA_PATH }})"
252251
CUDA_PYTHON_PARALLEL_LEVEL=${{ env.CUDA_PYTHON_PARALLEL_LEVEL }}
253252
UV_BUILD_CONSTRAINT="$(cygpath -w ./wheel-constraints/cuda-bindings.txt)"
254-
UV_CONSTRAINT="$(cygpath -w ./wheel-constraints/cuda-bindings.txt)"
255-
# check cache stats before leaving cibuildwheel
256-
CIBW_BEFORE_TEST_LINUX: >
253+
# Dump sccache stats during repair; no dummy test stage.
254+
CIBW_REPAIR_WHEEL_COMMAND_LINUX: >
257255
"/host/${{ env.SCCACHE_PATH }}" --show-adv-stats &&
258-
"/host/${{ env.SCCACHE_PATH }}" --show-stats --stats-format=json > /host/${{ github.workspace }}/sccache_bindings.json
259-
# force the test stage to be run (so that before-test is not skipped)
260-
# TODO: we might want to think twice on adding this, it does a lot of
261-
# things before reaching this command.
262-
CIBW_TEST_COMMAND: >
263-
echo "ok!"
256+
"/host/${{ env.SCCACHE_PATH }}" --show-stats --stats-format=json > /host/${{ github.workspace }}/sccache_bindings.json &&
257+
auditwheel repair -w {dest_dir} {wheel}
264258
265259
- name: Report sccache stats (cuda.bindings)
266260
if: ${{ env.BUILD_BINDINGS == 'true' && !startsWith(inputs.host-platform, 'win') }}
@@ -340,7 +334,6 @@ jobs:
340334
CUDA_PYTHON_PARALLEL_LEVEL=${{ env.CUDA_PYTHON_PARALLEL_LEVEL }}
341335
CUDA_CORE_BUILD_MAJOR=${{ env.BUILD_CUDA_MAJOR }}
342336
UV_BUILD_CONSTRAINT=/host/${{ github.workspace }}/wheel-constraints/cuda-core.txt
343-
UV_CONSTRAINT=/host/${{ github.workspace }}/wheel-constraints/cuda-core.txt
344337
CC="/host/${{ env.SCCACHE_PATH }} cc"
345338
CXX="/host/${{ env.SCCACHE_PATH }} c++"
346339
SCCACHE_GHA_ENABLED=true
@@ -354,16 +347,11 @@ jobs:
354347
CUDA_PYTHON_PARALLEL_LEVEL=${{ env.CUDA_PYTHON_PARALLEL_LEVEL }}
355348
CUDA_CORE_BUILD_MAJOR=${{ env.BUILD_CUDA_MAJOR }}
356349
UV_BUILD_CONSTRAINT="$(cygpath -w ./wheel-constraints/cuda-core.txt)"
357-
UV_CONSTRAINT="$(cygpath -w ./wheel-constraints/cuda-core.txt)"
358-
# check cache stats before leaving cibuildwheel
359-
CIBW_BEFORE_TEST_LINUX: >
360-
"/host${{ env.SCCACHE_PATH }}" --show-adv-stats &&
361-
"/host${{ env.SCCACHE_PATH }}" --show-stats --stats-format=json > /host/${{ github.workspace }}/sccache_core.json
362-
# force the test stage to be run (so that before-test is not skipped)
363-
# TODO: we might want to think twice on adding this, it does a lot of
364-
# things before reaching this command.
365-
CIBW_TEST_COMMAND: >
366-
echo "ok!"
350+
# Dump sccache stats during repair; no dummy test stage.
351+
CIBW_REPAIR_WHEEL_COMMAND_LINUX: >
352+
"/host/${{ env.SCCACHE_PATH }}" --show-adv-stats &&
353+
"/host/${{ env.SCCACHE_PATH }}" --show-stats --stats-format=json > /host/${{ github.workspace }}/sccache_core.json &&
354+
auditwheel repair -w {dest_dir} {wheel}
367355
368356
- name: Report sccache stats (cuda.core)
369357
if: ${{ env.BUILD_CORE == 'true' && !startsWith(inputs.host-platform, 'win') }}
@@ -628,7 +616,6 @@ jobs:
628616
CUDA_PYTHON_PARALLEL_LEVEL=${{ env.CUDA_PYTHON_PARALLEL_LEVEL }}
629617
CUDA_CORE_BUILD_MAJOR=${{ env.BUILD_PREV_CUDA_MAJOR }}
630618
UV_BUILD_CONSTRAINT=/host/${{ github.workspace }}/wheel-constraints/cuda-core-prev.txt
631-
UV_CONSTRAINT=/host/${{ github.workspace }}/wheel-constraints/cuda-core-prev.txt
632619
CC="/host/${{ env.SCCACHE_PATH }} cc"
633620
CXX="/host/${{ env.SCCACHE_PATH }} c++"
634621
SCCACHE_GHA_ENABLED=true
@@ -642,16 +629,11 @@ jobs:
642629
CUDA_PYTHON_PARALLEL_LEVEL=${{ env.CUDA_PYTHON_PARALLEL_LEVEL }}
643630
CUDA_CORE_BUILD_MAJOR=${{ env.BUILD_PREV_CUDA_MAJOR }}
644631
UV_BUILD_CONSTRAINT="$(cygpath -w ./wheel-constraints/cuda-core-prev.txt)"
645-
UV_CONSTRAINT="$(cygpath -w ./wheel-constraints/cuda-core-prev.txt)"
646-
# check cache stats before leaving cibuildwheel
647-
CIBW_BEFORE_TEST_LINUX: >
648-
"/host${{ env.SCCACHE_PATH }}" --show-adv-stats &&
649-
"/host${{ env.SCCACHE_PATH }}" --show-stats --stats-format=json > /host/${{ github.workspace }}/sccache_core_prev.json
650-
# force the test stage to be run (so that before-test is not skipped)
651-
# TODO: we might want to think twice on adding this, it does a lot of
652-
# things before reaching this command.
653-
CIBW_TEST_COMMAND: >
654-
echo "ok!"
632+
# Dump sccache stats during repair; no dummy test stage.
633+
CIBW_REPAIR_WHEEL_COMMAND_LINUX: >
634+
"/host/${{ env.SCCACHE_PATH }}" --show-adv-stats &&
635+
"/host/${{ env.SCCACHE_PATH }}" --show-stats --stats-format=json > /host/${{ github.workspace }}/sccache_core_prev.json &&
636+
auditwheel repair -w {dest_dir} {wheel}
655637
656638
- name: Report sccache stats (cuda.core prev)
657639
if: ${{ !inputs.single-cuda-major && env.BUILD_CORE == 'true' && !startsWith(inputs.host-platform, 'win') }}

0 commit comments

Comments
 (0)