Repository navigation
Commit acfe5f1
committed
refactor(pathfinder): apply review feedback on binary finder
- Rename _is_executable_file to _is_executable_candidate; the helper marks
a return candidate rather than proving OS executability. Drop its docstring
now that the name is self-explanatory, and update the test patch target.
- Drop the 'ambient PATH is never consulted' sentence from
resolve_ctk_root_via_canary; it is not universally true.
Signed-off-by: Aryan <[email protected]>1 parent c28e7b2 commit acfe5f1
3 files changed
Lines changed: 5 additions & 11 deletions
File tree
- cuda_pathfinder
- cuda/pathfinder
- _binaries
- _dynamic_libs
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
| 31 | + | |
38 | 32 | | |
39 | 33 | | |
40 | 34 | | |
| |||
68 | 62 | | |
69 | 63 | | |
70 | 64 | | |
71 | | - | |
| 65 | + | |
72 | 66 | | |
73 | 67 | | |
74 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | | - | |
| 146 | + | |
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
0 commit comments