Skip to content

Commit a4f5ee4

Browse files
committed
Coderabbit commets
1 parent 0062635 commit a4f5ee4

2 files changed

Lines changed: 17 additions & 3 deletions

File tree

‎.github/RELEASE-core.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,16 @@ and wheels. It publishes to TestPyPI followed by PyPI, then publishes the
1919
GitHub Release without marking it as latest. A failed
2020
docs build prevents asset uploads, package publication, and finalization.
2121

22+
The release-note checker runs from `git-tag`, not the workflow revision.
23+
For a Pathfinder `full-release`, that tag must contain a version
24+
of `ci/tools/check_release_notes.py` that writes `version=<VERSION>` to
25+
`GITHUB_OUTPUT`. Metadata preparation and finalization reject an empty
26+
version. Do not dispatch `full-release` for older tags without that support:
27+
the GitHub Release cannot be finalized, although shared documentation,
28+
asset upload, and package publication jobs can still run. Use the retained
29+
legacy Pathfinder workflow for those tags during the transition; do not
30+
move existing tags to add the updated checker.
31+
2232
The default `dry-run` action validates preparation, builds docs, and
2333
collects release artifacts without creating a GitHub Release or publishing
2434
packages. It can be dispatched from a development branch; use

‎.github/workflows/release.yml‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,11 +187,15 @@ jobs:
187187

188188
- name: Check versioned release notes exist
189189
id: release-notes
190+
env:
191+
RELEASE_GIT_TAG: ${{ inputs.git-tag }}
192+
RELEASE_COMPONENT: ${{ inputs.component }}
193+
BACKPORT_GIT_TAG: ${{ inputs.backport-git-tag }}
190194
run: |
191195
python ci/tools/check_release_notes.py \
192-
--git-tag "${{ inputs.git-tag }}" \
193-
--component "${{ inputs.component }}" \
194-
--backport-git-tag "${{ inputs.backport-git-tag }}"
196+
--git-tag "$RELEASE_GIT_TAG" \
197+
--component "$RELEASE_COMPONENT" \
198+
--backport-git-tag "$BACKPORT_GIT_TAG"
195199
196200
ensure-pathfinder-draft:
197201
name: Prepare Pathfinder release draft

0 commit comments

Comments
 (0)